[GitHub] [airflow] joshowen commented on a change in pull request #9452: JSON serialize Log extras

[GitBox <gi...@apache.org>]

joshowen commented on a change in pull request #9452:
URL: https://github.com/apache/airflow/pull/9452#discussion_r450764948



##########
File path: airflow/www/decorators.py
##########
@@ -44,7 +45,7 @@ def wrapper(*args, **kwargs):
                 event=f.__name__,
                 task_instance=None,
                 owner=user,
-                extra=str(list(request.values.items())),
+                extra=json.dumps(request.values),

Review comment:
       @kaxil to give more color, we've built an "Airflow Snitch" which alerts based on some user actions (eg user cleared a production DAG).  This relies on parsing the `extra` field to determine if the job was actually cleared since there are two trigger events, and only the `confirmed` event causes an action.
   
   We've hacked together some `extra` field parsing, but it isn't very elegant, and this could be done a lot more efficiently in the database if the column was valid json.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org