You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2010/04/27 06:00:26 UTC
svn commit: r938314 - in /hadoop/hbase/branches/0.20: CHANGES.txt
src/java/org/apache/hadoop/hbase/regionserver/HLog.java
Author: stack
Date: Tue Apr 27 04:00:26 2010
New Revision: 938314
URL: http://svn.apache.org/viewvc?rev=938314&view=rev
Log:
HBASE-2476 HLog sequence number is obtained outside updateLock
Modified:
hadoop/hbase/branches/0.20/CHANGES.txt
hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HLog.java
Modified: hadoop/hbase/branches/0.20/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/CHANGES.txt?rev=938314&r1=938313&r2=938314&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/CHANGES.txt (original)
+++ hadoop/hbase/branches/0.20/CHANGES.txt Tue Apr 27 04:00:26 2010
@@ -101,6 +101,8 @@ Release 0.20.4 - Unreleased
HBASE-2381 missing copyright headers (Andrew Purtell via Stack)
HBASE-2487 Uncaught exceptions in receiving IPC responses orphan clients
(Todd Lipcon via Stack)
+ HBASE-2476 HLog sequence number is obtained outside updateLock
+ (Todd Lipcon via Stack)
IMPROVEMENTS
HBASE-2180 Bad read performance from synchronizing hfile.fddatainputstream
Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HLog.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HLog.java?rev=938314&r1=938313&r2=938314&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HLog.java (original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HLog.java Tue Apr 27 04:00:26 2010
@@ -719,9 +719,9 @@ public class HLog implements HConstants,
if (this.closed) {
throw new IOException("Cannot append; log is closed");
}
- long seqNum = obtainSeqNum();
synchronized (this.updateLock) {
+ long seqNum = obtainSeqNum();
// The 'lastSeqWritten' map holds the sequence number of the oldest
// write for each region (i.e. the first edit added to the particular
// memstore). . When the cache is flushed, the entry for the