You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/04 10:05:41 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32432: [SPARK-35308][FOLLOW-UP][TESTS] Fix bug in SPARK-35266 that creates benchmark files in invalid path with wrong name

HyukjinKwon commented on a change in pull request #32432:
URL: https://github.com/apache/spark/pull/32432#discussion_r625659857



##########
File path: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala
##########
@@ -56,7 +56,7 @@ abstract class BenchmarkBase {
         // scalastyle:on println
         dir.mkdirs()
       }
-      val file = new File(s"${dir}$resultFileName")
+      val file = new File(s"${dir.getCanonicalPath}/$resultFileName")

Review comment:
       ```suggestion
         val file = new File(dir, resultFileName)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org