[GitHub] [ozone] adoroszlai commented on a change in pull request #1955: HDDS-4840. Make datanode db profile configurable with existing hdds.d…

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #1955:
URL: https://github.com/apache/ozone/pull/1955#discussion_r582000395



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/AbstractDatanodeStore.java
##########
@@ -89,11 +91,14 @@ protected AbstractDatanodeStore(ConfigurationSource config, long containerID,
       AbstractDatanodeDBDefinition dbDef, boolean openReadOnly)
       throws IOException {
 
+    dbProfile = config.getEnum(HDDS_DB_PROFILE,
+        HDDS_DEFAULT_DB_PROFILE);
+
     // The same config instance is used on each datanode, so we can share the
     // corresponding column family options, providing a single shared cache
     // for all containers on a datanode.
     if (!OPTIONS_CACHE.containsKey(config)) {
-      OPTIONS_CACHE.put(config, buildColumnFamilyOptions(config));
+      OPTIONS_CACHE.put(config, buildColumnFamilyOptions(config, dbProfile));

Review comment:
       Nit: instead of passing `dbProfile` member variable, can you please make `buildColumnFamilyOptions` non-static?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org