You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/02/08 13:55:32 UTC

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #156: Clarify level of repoinit support

kwin commented on code in PR #156:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/156#discussion_r1100173688


##########
README.md:
##########
@@ -411,6 +411,11 @@ While scanning the input content-package(s), all ACLs entries are handled by the
 
 Default implementation is provided by [org.apache.sling.feature.cpconverter.acl.DefaultAclManager](./src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java).
 
+When using a seed feature, repoinit instructions will be parsed to extract system user ids. The supported repoinit instructions are the ones known to the Repoinit Parser version 1.7.0, notably missing support for:
+
+- `ensure nodes`
+- `ensure principal ACL`

Review Comment:
   probably also the statements from https://issues.apache.org/jira/browse/SLING-11571 are not supported.



##########
README.md:
##########
@@ -411,6 +411,11 @@ While scanning the input content-package(s), all ACLs entries are handled by the
 
 Default implementation is provided by [org.apache.sling.feature.cpconverter.acl.DefaultAclManager](./src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java).
 
+When using a seed feature, repoinit instructions will be parsed to extract system user ids. The supported repoinit instructions are the ones known to the Repoinit Parser version 1.7.0, notably missing support for:
+
+- `ensure nodes`
+- `ensure principal ACL`

Review Comment:
   probably also the statements from https://issues.apache.org/jira/browse/SLING-11571 (introduced in 1.8) are not supported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org