You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Kjell Andreassen (JIRA)" <ji...@apache.org> on 2011/07/28 16:52:09 UTC

[jira] [Created] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Allow cassandra to start on a Solaris machine.
----------------------------------------------

                 Key: CASSANDRA-2965
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
             Project: Cassandra
          Issue Type: Improvement
          Components: Packaging
    Affects Versions: 0.8.2
         Environment: Solaris 10/SunOS 5.10, x86 architecture.
            Reporter: Kjell Andreassen
            Priority: Trivial
             Fix For: 0.8.3


Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.

These are the errors:
bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
bin/cassandra: test: argument expected


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2965:
--------------------------------------

    Reviewer: thepaul
    Assignee: Kjell Andreassen

> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Assignee: Kjell Andreassen
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073117#comment-13073117 ] 

Hudson commented on CASSANDRA-2965:
-----------------------------------

Integrated in Cassandra-0.8 #245 (See [https://builds.apache.org/job/Cassandra-0.8/245/])
    improved POSIX compatibility of start scripts
patch by Kjell Andreassen and Paul Cannon for CASSANDRA-2965

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152421
Files : 
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/conf/cassandra-env.sh
* /cassandra/branches/cassandra-0.8/bin/cassandra


> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Assignee: Kjell Andreassen
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: 0001-Solaris-bin-sh-compatibility.patch.txt, 0002-improve-general-sh-compatibility.patch.txt, cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "paul cannon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

paul cannon updated CASSANDRA-2965:
-----------------------------------

    Attachment: 0002-improve-general-sh-compatibility.patch.txt
                0001-Solaris-bin-sh-compatibility.patch.txt

0001: just Kjell's original patch, rebased after #2785
0002: several other places where it would be a good idea for general compatibility or safety to quote shell variables

I don't have access to a Solaris machine to actually test, but this works under dash, and I'm pretty confident it's good. Kjell, would you mind giving it a few extra tests on actual Solaris?

> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Assignee: Kjell Andreassen
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: 0001-Solaris-bin-sh-compatibility.patch.txt, 0002-improve-general-sh-compatibility.patch.txt, cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "Kjell Andreassen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072929#comment-13072929 ] 

Kjell Andreassen commented on CASSANDRA-2965:
---------------------------------------------

It works beautifully.

Cassandra started without warnings/errors and is talking to the other nodes on a Solaris (uname -a: SunOS <hostname> 5.10 Generic_142901-11 i86pc i386 i86pc) after applying patches 1 and 2 from #2785 and patches 1 and 2 from this issue (#2965) on top of cassandra-0.8.2 (207f0a).


> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Assignee: Kjell Andreassen
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: 0001-Solaris-bin-sh-compatibility.patch.txt, 0002-improve-general-sh-compatibility.patch.txt, cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "paul cannon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

paul cannon reassigned CASSANDRA-2965:
--------------------------------------

    Assignee: Eric Evans  (was: Kjell Andreassen)

+1 for 0001, 0002 then.

> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Assignee: Eric Evans
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: 0001-Solaris-bin-sh-compatibility.patch.txt, 0002-improve-general-sh-compatibility.patch.txt, cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "Kjell Andreassen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072388#comment-13072388 ] 

Kjell Andreassen edited comment on CASSANDRA-2965 at 7/28/11 3:02 PM:
----------------------------------------------------------------------

Solaris 10 doesn't seem to like modern things like $() and $(()). They are replaced by `` and `expr` in the patch attached.

Also a 'SunOS' section for the uname/memory switch is in the patch.

      was (Author: andreassen.kjell@gmail.com):
    Solaris 10 doesn't seem to like modern things like $() and $(()). They are replaced by `` and `expr` in this patch.

Also a 'SunOS' section for the uname/memory switch.
  
> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "Kjell Andreassen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kjell Andreassen updated CASSANDRA-2965:
----------------------------------------

    Attachment: cassandra-0.8.2-2965.txt

> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CASSANDRA-2965) Allow cassandra to start on a Solaris machine.

Posted by "Kjell Andreassen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072388#comment-13072388 ] 

Kjell Andreassen edited comment on CASSANDRA-2965 at 7/28/11 3:03 PM:
----------------------------------------------------------------------

The default shell in Solaris 10 doesn't seem to like modern things like $() and $(()). They are replaced by `` and `expr` in the patch attached.

Also a 'SunOS' section for the uname/memory switch is in the patch.

      was (Author: andreassen.kjell@gmail.com):
    Solaris 10 doesn't seem to like modern things like $() and $(()). They are replaced by `` and `expr` in the patch attached.

Also a 'SunOS' section for the uname/memory switch is in the patch.
  
> Allow cassandra to start on a Solaris machine.
> ----------------------------------------------
>
>                 Key: CASSANDRA-2965
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2965
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 0.8.2
>         Environment: Solaris 10/SunOS 5.10, x86 architecture.
>            Reporter: Kjell Andreassen
>            Priority: Trivial
>             Fix For: 0.8.3
>
>         Attachments: cassandra-0.8.2-2965.txt
>
>
> Cassandra ($CASSANDRA_HOME/bin/cassandra) fails to start with a series of errors, fixing one reveals the next.
> These are the errors:
> bin/cassandra: syntax error at line 27: `system_memory_in_mb=$' unexpected
> bin/cassandra: syntax error at line 100: `check_openjdk=$' unexpected
> bin/cassandra: test: argument expected

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira