You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Sanjeev Anand <Sa...@india.nec.com> on 2019/06/13 10:04:59 UTC

Discussion regarding PR#440 closure

Hi Team,

We are working on PR440 for Bug #63130 to incorporate the valuable comments of community members.
PR 440 was closed on 8th June 2019, but it seems that changes related to fix of bug #63130 was missed to commit.

We checked the below commit logs related to Bug #63130.
https://github.com/apache/jmeter/commit/980bb0ea558434e1651ceba804fc588ecaa5b42f
But the change of API URLDecoder to URLCodec was missed to commit.

Request you to please check and confirm, if this is being done by mistake, as bug#63130 still stand open.
We are eager to provide the solution to bug #63130.

Can you please confirm, shall we raise a new PR or existing PR shall be reopen.

Regards,
Sanjeev Anand

Re: Discussion regarding PR#440 closure

Posted by sebb <se...@gmail.com>.
On Thu, 13 Jun 2019 at 12:24, Philippe Mouawad
<ph...@gmail.com> wrote:
>
> Hello,
> Due to git migration , all PRs were automatically closed.

FTR, part of the migration involved dropping the trunk branch in
favour of master.
PRs against trunk were auto-closed when trunk was deleted.

> So you need to raise a new one.
>
>
> Regards
>
> On Thu, Jun 13, 2019 at 1:06 PM Sanjeev Anand <Sa...@india.nec.com>
> wrote:
>
> > Dear Vladimir,
> >
> > Yes, commit 980bb0ea558434e1651ceba804fc588ecaa5b42f isn't related to
> > bug#63130.
> >
> > PR#440 contained changes related to bug#63130 but it was closed without
> > merging the commits.
> >
> > Kindly suggest, if we need to raise separate PR for same.
> >
> >
> > Regards,
> > Sanjeev Anand
> >
> > -----Original Message-----
> > From: Vladimir Sitnikov [mailto:sitnikov.vladimir@gmail.com]
> > Sent: Thursday, June 13, 2019 3:41 PM
> > To: ApacheJMeter dev list <de...@jmeter.apache.org>
> > Subject: Re: Discussion regarding PR#440 closure
> >
> > Please follow SVN -> Git migration on the mailing list:
> >
> > https://lists.apache.org/thread.html/4f977752f0adfb8a21242c88e4e13ad2dad383b947c7f93106b93368@%3Cdev.jmeter.apache.org%3E
> >
> > Sanjeev>We checked the below commit logs related to Bug #63130
> >
> > Why do you think the commit 980bb0ea558434e1651ceba804fc588ecaa5b42f is
> > related to bug 63130?
> >
> > Vladimir
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: Discussion regarding PR#440 closure

Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
Due to git migration , all PRs were automatically closed.
So you need to raise a new one.


Regards

On Thu, Jun 13, 2019 at 1:06 PM Sanjeev Anand <Sa...@india.nec.com>
wrote:

> Dear Vladimir,
>
> Yes, commit 980bb0ea558434e1651ceba804fc588ecaa5b42f isn't related to
> bug#63130.
>
> PR#440 contained changes related to bug#63130 but it was closed without
> merging the commits.
>
> Kindly suggest, if we need to raise separate PR for same.
>
>
> Regards,
> Sanjeev Anand
>
> -----Original Message-----
> From: Vladimir Sitnikov [mailto:sitnikov.vladimir@gmail.com]
> Sent: Thursday, June 13, 2019 3:41 PM
> To: ApacheJMeter dev list <de...@jmeter.apache.org>
> Subject: Re: Discussion regarding PR#440 closure
>
> Please follow SVN -> Git migration on the mailing list:
>
> https://lists.apache.org/thread.html/4f977752f0adfb8a21242c88e4e13ad2dad383b947c7f93106b93368@%3Cdev.jmeter.apache.org%3E
>
> Sanjeev>We checked the below commit logs related to Bug #63130
>
> Why do you think the commit 980bb0ea558434e1651ceba804fc588ecaa5b42f is
> related to bug 63130?
>
> Vladimir
>


-- 
Cordialement.
Philippe Mouawad.

RE: Discussion regarding PR#440 closure

Posted by Sanjeev Anand <Sa...@india.nec.com>.
Dear Vladimir,

Yes, commit 980bb0ea558434e1651ceba804fc588ecaa5b42f isn't related to bug#63130. 

PR#440 contained changes related to bug#63130 but it was closed without merging the commits. 

Kindly suggest, if we need to raise separate PR for same.


Regards,
Sanjeev Anand

-----Original Message-----
From: Vladimir Sitnikov [mailto:sitnikov.vladimir@gmail.com] 
Sent: Thursday, June 13, 2019 3:41 PM
To: ApacheJMeter dev list <de...@jmeter.apache.org>
Subject: Re: Discussion regarding PR#440 closure

Please follow SVN -> Git migration on the mailing list:
https://lists.apache.org/thread.html/4f977752f0adfb8a21242c88e4e13ad2dad383b947c7f93106b93368@%3Cdev.jmeter.apache.org%3E

Sanjeev>We checked the below commit logs related to Bug #63130

Why do you think the commit 980bb0ea558434e1651ceba804fc588ecaa5b42f is related to bug 63130?

Vladimir

Re: Discussion regarding PR#440 closure

Posted by Vladimir Sitnikov <si...@gmail.com>.
Please follow SVN -> Git migration on the mailing list:
https://lists.apache.org/thread.html/4f977752f0adfb8a21242c88e4e13ad2dad383b947c7f93106b93368@%3Cdev.jmeter.apache.org%3E

Sanjeev>We checked the below commit logs related to Bug #63130

Why do you think the commit 980bb0ea558434e1651ceba804fc588ecaa5b42f is
related to bug 63130?

Vladimir