You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "aryangupta1998 (via GitHub)" <gi...@apache.org> on 2023/11/02 20:00:08 UTC
[PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
aryangupta1998 opened a new pull request, #5541:
URL: https://github.com/apache/ozone/pull/5541
## What changes were proposed in this pull request?
For closed containers, the pipeline ID keeps on changing on every request, it's randomly generating everytime we execute the container info command. To address this issue we directly fetch the pipeline ID from scm client via container info and display it in the implementation of container info command instead of displaying the random pipeline ID assigned during the creation of pipeline when container are closed.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9544
## How was this patch tested?
Tested Manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl merged PR #5541:
URL: https://github.com/apache/ozone/pull/5541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1382925256
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -105,10 +108,20 @@ public void execute(ScmClient scmClient) throws IOException {
&& spec.root().userObject() instanceof GenericParentCommand
&& ((GenericParentCommand) spec.root().userObject()).isVerbose();
if (verbose) {
- LOG.info("Pipeline Info: {}", container.getPipeline());
+ Pipeline pipeline = null;
Review Comment:
We can use the same pipeline info object as above (container.getPipeline()) as we have introduced a new field to denote original write pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1820651991
@sumitagrawl please set fix version in Jira when merging PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1814639382
@nandakumar131 , This patch doesn't modify the pipelineInfo/pipelineID that gets printed as part of container info command, but rather adds a new field that stores the RatisPipelineID that the container was initially created on during OPEN/CLOSING states. This can be helpful in debugging issues using the ratisPipelineID say if one has to look into the logs to understand the lifecycle of that pipeline. Using only ephemeral pipeline here is confusing as it is newly generated everytime for a read and one will assume that the pipeline never got created if logs are searched using it.
Can we still move forward with this patch as a debugging improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1815574491
I agree with @sadanand48 we need to make these troubleshooting CLIs as intuitive as possible. Returning the write pipeline that was used when writing to the container is useful to cross check with history in the logs logs, and if the pipeline is still active it can be cross checked with `ozone admin pipeline list`. The new output specifies that what is being returned is the "write pipeline".
I have never heard of this term "simple pipeline" and I think it is safe to say most Ozone users have not either. I can't even find evidence to back up this term from the code, because there it defines [simple pipeline as a standalone pipeline](https://github.com/apache/ozone/blob/e360de03375e5204857626b6949e7a2f61721d29/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SimplePipelineProvider.java#L36).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1398751738
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +111,16 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
+ container.getContainerInfo().getPipelineID().getId());
+ try {
+ String pipelineState = scmClient.getPipeline(
+ container.getContainerInfo().getPipelineID().getProtobuf())
+ .getPipelineState().toString();
+ LOG.info("Write Pipeline State: {}", pipelineState);
+ } catch (IOException ioe) {
Review Comment:
```suggestion
} catch (IOException ioe) {
if (SCMHAUtils.unwrapException(
ioe) instanceof PipelineNotFoundException) {
LOG.info("Write Pipeline State: CLOSED");
} else {
LOG.error("Failed to retrieve pipeline info");
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1808949117
> For #createForRead -> #create, we have hardcoded the pipeline state to ALLOCATED in case the containers are closed and we create a new pipeline for read. Anyways, after the pipeline is closed it will be removed from the DB so the state doesn't matter much. As of now, we support 4 states {ALLOCATED, OPEN, DORMANT, CLOSED}, can you suggest which state should we use?
Ideally we would use the actual state of the pipeline if present, or CLOSED if the pipeline is no longer present in SCM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1813978661
A container is part of only one Pipeline at any point of time. When the container is in `OPEN/CLOSING` state they are managed by Ratis Pipeline.
Once the container is `CLOSED/QUASI_CLOSED`, they are managed using Simple Pipeline.
Simple Pipelines are kinda ephemeral, they are easy to create and are stateless. Simple Pipeline informations are not stored.
Whenever a client requests for the Pipeline of `CLOSED/QUASI_CLOSED` Container, Simple Pipeline is created on the fly and handed over to the client, so the PipelineID is randomly generated. This causes the PipelineID to change every time. This is expected behaviour.
One improvement that we can do is to try and generate the same PipelineID every time (for the same set of Datanodes) using `UUID.nameUUIDFromBytes` API. By doing this we will be generating the same PipelineID for every call for same set of Datanodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "aryangupta1998 (via GitHub)" <gi...@apache.org>.
aryangupta1998 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1398757136
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +111,16 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
+ container.getContainerInfo().getPipelineID().getId());
+ try {
+ String pipelineState = scmClient.getPipeline(
+ container.getContainerInfo().getPipelineID().getProtobuf())
+ .getPipelineState().toString();
+ LOG.info("Write Pipeline State: {}", pipelineState);
+ } catch (IOException ioe) {
+ LOG.info("Write Pipeline State: CLOSED");
+ }
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1398751738
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +111,16 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
+ container.getContainerInfo().getPipelineID().getId());
+ try {
+ String pipelineState = scmClient.getPipeline(
+ container.getContainerInfo().getPipelineID().getProtobuf())
+ .getPipelineState().toString();
+ LOG.info("Write Pipeline State: {}", pipelineState);
+ } catch (IOException ioe) {
Review Comment:
```suggestion
} catch (IOException ioe) {
if (SCMHAUtils.unwrapException(
ioe) instanceof PipelineNotFoundException) {
LOG.info("Write Pipeline State: CLOSED");
} else {
LOG.error("Failed to retrieve pipeline info");
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1398754943
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +111,16 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
+ container.getContainerInfo().getPipelineID().getId());
+ try {
+ String pipelineState = scmClient.getPipeline(
+ container.getContainerInfo().getPipelineID().getProtobuf())
+ .getPipelineState().toString();
+ LOG.info("Write Pipeline State: {}", pipelineState);
+ } catch (IOException ioe) {
+ LOG.info("Write Pipeline State: CLOSED");
+ }
Review Comment:
```suggestion
} catch (IOException ioe) {
if (SCMHAUtils.unwrapException(
ioe) instanceof PipelineNotFoundException) {
LOG.info("Write Pipeline State: CLOSED");
} else {
LOG.error("Failed to retrieve pipeline info");
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1804422168
Current change looks good to me as the original write pipeline info is displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "aryangupta1998 (via GitHub)" <gi...@apache.org>.
aryangupta1998 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1799780135
> Can we update this change to handle [this issue](https://issues.apache.org/jira/browse/HDDS-9544?focusedCommentId=17780526&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17780526) as well? They come from the same method in the code.
For #createForRead -> #create, we have hardcoded the pipeline state to ALLOCATED in case the containers are closed and we create a new pipeline for read. Anyways, after the pipeline is closed it will be removed from the DB so the state doesn't matter much. As of now, we support 4 states {ALLOCATED, OPEN, DORMANT, CLOSED}, can you suggest which state should we use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1815977320
> I have never heard of this term "simple pipeline" and I think it is safe to say most Ozone users have not either.
During the very early stage of Ozone development Standalone Pipeline was created to write data to single datanode (That is where the name 'Standalone' comes from), later it was repurposed to use it in read path. There was a plan to refactor and rename the Standalone Pipeline, that never happened.
Now it's too late for the refactoring. 🙂
@sadanand48 @errose28
If the change is for making the troubleshooting process easier, I'm +1
The title is misleading since it says 'Incorrect pipeline ID'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "aryangupta1998 (via GitHub)" <gi...@apache.org>.
aryangupta1998 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1399378903
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +113,21 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
Review Comment:
Both are different, in else we have Pipeline Id(container.getPipeline().getId().getId()) and below we have Write Pipeline Id(container.getContainerInfo().getPipelineID().getId()).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1396791380
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +111,16 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
+ container.getContainerInfo().getPipelineID().getId());
+ try {
+ String pipelineState = scmClient.getPipeline(
+ container.getContainerInfo().getPipelineID().getProtobuf())
+ .getPipelineState().toString();
+ LOG.info("Write Pipeline State: {}", pipelineState);
+ } catch (IOException ioe) {
Review Comment:
Check for PipelineNotFoundException specifically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1399188145
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +113,21 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
Review Comment:
Already logging pipeline Id in if/else block, this is redundant, above can be modified if requried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1399441961
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +113,21 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
Review Comment:
@sumitagrawl "Write Pipeline ID" represents original pipeline on which the container was created whereas once pipeline is closed we use random pipeline for read. These two values will be the same till pipeline is closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1819358629
> simple pipeline as a standalone pipeline
@nandakumar131 As checked code, createPipelineForRead is not more used and just returning random pipelineId. What if this code is changed to return existing pipeline Id itself? No need use pipelineProvider to create pipeline for read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1396791380
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -109,6 +111,16 @@ public void execute(ScmClient scmClient) throws IOException {
} else {
LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
}
+ LOG.info("Write PipelineId: {}",
+ container.getContainerInfo().getPipelineID().getId());
+ try {
+ String pipelineState = scmClient.getPipeline(
+ container.getContainerInfo().getPipelineID().getProtobuf())
+ .getPipelineState().toString();
+ LOG.info("Write Pipeline State: {}", pipelineState);
+ } catch (IOException ioe) {
Review Comment:
Check for PipelineNotFoundException specifically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1820633435
> What if this code is changed to return existing pipeline Id itself?
We cannot return the existing PipelineId as it is possible for the Container to get replicated on different datanodes once it is CLOSED. This will cause more confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1804423762
@errose28 would you like to take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #5541:
URL: https://github.com/apache/ozone/pull/5541#issuecomment-1796228142
Can we update this change to handle [this issue](https://issues.apache.org/jira/browse/HDDS-9544?focusedCommentId=17780526&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17780526) as well? They come from the same method in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9544. Incorrect pipeline ID and state for closed container. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5541:
URL: https://github.com/apache/ozone/pull/5541#discussion_r1385974463
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java:
##########
@@ -107,8 +109,11 @@ public void execute(ScmClient scmClient) throws IOException {
if (verbose) {
LOG.info("Pipeline Info: {}", container.getPipeline());
} else {
- LOG.info("Pipeline id: {}", container.getPipeline().getId().getId());
+ LOG.info("Pipeline id: {}",
Review Comment:
This also can be reverted as write pipeline Id already maintains the original pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org