You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/06/13 08:31:32 UTC

Review Request 60035: Added support for printing JSON values via `jsonify`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60035/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  3rdparty/stout/include/stout/json.hpp aa581c0345679b6f9617fb986d744110a728f042 
  3rdparty/stout/include/stout/jsonify.hpp 7d84bac18abbe9f5bcf67a377d4e742e31b4c94d 


Diff: https://reviews.apache.org/r/60035/diff/1/


Testing
-------


Thanks,

Michael Park


Re: Review Request 60035: Added support for printing JSON values via `jsonify`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60035/
-----------------------------------------------------------

(Updated June 13, 2017, 10:28 a.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Added support for printing JSON values via `jsonify`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/json.hpp aa581c0345679b6f9617fb986d744110a728f042 
  3rdparty/stout/include/stout/jsonify.hpp 7d84bac18abbe9f5bcf67a377d4e742e31b4c94d 
  3rdparty/stout/tests/jsonify_tests.cpp d06eba31e6b7f252b120a10066e4d7c9a25ce4b5 


Diff: https://reviews.apache.org/r/60035/diff/3/

Changes: https://reviews.apache.org/r/60035/diff/2-3/


Testing
-------

Added new tests + `make check`


Thanks,

Michael Park


Re: Review Request 60035: Added support for printing JSON values via `jsonify`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60035/
-----------------------------------------------------------

(Updated June 13, 2017, 10:10 a.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-----------------

Added support for printing JSON values via `jsonify`.


Repository: mesos


Description (updated)
-------

Added support for printing JSON values via `jsonify`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/json.hpp aa581c0345679b6f9617fb986d744110a728f042 
  3rdparty/stout/include/stout/jsonify.hpp 7d84bac18abbe9f5bcf67a377d4e742e31b4c94d 
  3rdparty/stout/tests/jsonify_tests.cpp d06eba31e6b7f252b120a10066e4d7c9a25ce4b5 


Diff: https://reviews.apache.org/r/60035/diff/2/

Changes: https://reviews.apache.org/r/60035/diff/1-2/


Testing (updated)
-------

Added new tests + `make check`


Thanks,

Michael Park


Re: Review Request 60035: WIP: Added support for printing JSON values via `jsonify`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60035/#review177709
-----------------------------------------------------------



Bad review!

Reviews applied: [60035, 59861, 59860, 59859, 58510, 58509, 58508, 57516, 58584, 57254, 58112, 58110, 57564, 57528, 57527, 57788, 57167, 57166, 56805, 57165, 57164]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On June 13, 2017, 1:31 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60035/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 1:31 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/json.hpp aa581c0345679b6f9617fb986d744110a728f042 
>   3rdparty/stout/include/stout/jsonify.hpp 7d84bac18abbe9f5bcf67a377d4e742e31b4c94d 
> 
> 
> Diff: https://reviews.apache.org/r/60035/diff/1/
> 
> 
> Testing
> -------
> 
> TODO
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 60035: WIP: Added support for printing JSON values via `jsonify`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60035/#review177708
-----------------------------------------------------------




3rdparty/stout/include/stout/json.hpp
Lines 711-714 (patched)
<https://reviews.apache.org/r/60035/#comment251438>

    Leave a comment about this.


- Michael Park


On June 13, 2017, 1:31 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60035/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 1:31 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/json.hpp aa581c0345679b6f9617fb986d744110a728f042 
>   3rdparty/stout/include/stout/jsonify.hpp 7d84bac18abbe9f5bcf67a377d4e742e31b4c94d 
> 
> 
> Diff: https://reviews.apache.org/r/60035/diff/1/
> 
> 
> Testing
> -------
> 
> TODO
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 60035: WIP: Added support for printing JSON values via `jsonify`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60035/
-----------------------------------------------------------

(Updated June 13, 2017, 1:31 a.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-----------------

WIP: Added support for printing JSON values via `jsonify`.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  3rdparty/stout/include/stout/json.hpp aa581c0345679b6f9617fb986d744110a728f042 
  3rdparty/stout/include/stout/jsonify.hpp 7d84bac18abbe9f5bcf67a377d4e742e31b4c94d 


Diff: https://reviews.apache.org/r/60035/diff/1/


Testing (updated)
-------

TODO


Thanks,

Michael Park