You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/04/12 17:15:31 UTC
[GitHub] [httpcomponents-core] peterdettman opened a new pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
peterdettman opened a new pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283
https://issues.apache.org/jira/browse/HTTPCLIENT-1916 .
Note that I have marked the new method as "since 5.2".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283#issuecomment-818002614
May you please test edge cases like null and ""?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] peterdettman commented on pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
Posted by GitBox <gi...@apache.org>.
peterdettman commented on pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283#issuecomment-818014683
@michael-o Some rationale was given by the submitter; I am merely picking up a _volunteers-wanted_ label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283#issuecomment-818477704
>
>
> I'm happy to add such tests, but I'm a bit unclear what the expected behaviour ought to be. I'm inclined to require non-null, non-empty for `param` but actually other `URIBuilder` methods don't seem to exclude "" for a name (is that really permissible?). `BasicNameValuePair` guards only against null too).
@peterdettman I think just `null` check should be enough for now. The issue of name/value pairs with an empty name should be dealt with consistently across the entire library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] peterdettman commented on pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
Posted by GitBox <gi...@apache.org>.
peterdettman commented on pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283#issuecomment-818492672
I've added a null guard for the argument, with accompanying test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283#issuecomment-818011564
Why is a remove method necessary in a builder? Coming from a pre-built URI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] peterdettman commented on pull request #283: HTTPCLIENT-1916: Add URIBuilder.removeParameter
Posted by GitBox <gi...@apache.org>.
peterdettman commented on pull request #283:
URL: https://github.com/apache/httpcomponents-core/pull/283#issuecomment-818011495
I'm happy to add such tests, but I'm a bit unclear what the expected behaviour ought to be. I'm inclined to require non-null, non-empty for `param` but actually other `URIBuilder` methods don't seem to exclude "" for a name (is that really permissible?). `BasicNameValuePair` guards only against null too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org