You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/22 07:11:59 UTC

[GitHub] [maven-invoker-plugin] pzygielo opened a new pull request #23: [MINVOKER-254] Bump groovy to the latest in 2.4

pzygielo opened a new pull request #23:
URL: https://github.com/apache/maven-invoker-plugin/pull/23


   As [3.2.2](https://issues.apache.org/jira/projects/MINVOKER/versions/12346157) is still unreleased, I think this change can be covered by [MINVOKER-254](https://issues.apache.org/jira/browse/MINVOKER-254).
   
   [Changes in Groovy 2.4.20](http://groovy-lang.org/changelogs/changelog-2.4.20.html)
   
   As follow-up to #15.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-invoker-plugin] pzygielo commented on pull request #23: [MINVOKER-254] Bump groovy to the latest in 2.4

Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #23:
URL: https://github.com/apache/maven-invoker-plugin/pull/23#issuecomment-662292656


   > I have plans to try upgrade to Groovy 2.5
   
   I shared argument to not do it for this release in MINVOKER-254.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #23: [MINVOKER-254] Bump groovy to the latest in 2.4

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #23:
URL: https://github.com/apache/maven-invoker-plugin/pull/23#issuecomment-662297295


   IMHO dependency for groovy should be taken from `maven-script-interpreter` and should be only for core groovy.
   
   If someone needs any groovy extension should add dependency to self project.
   
   Currently I'm working on `maven-script-interpreter` which will have many code cleanup and break compatibility - so I will have to do some changes in `maven-invoker-plugin`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-invoker-plugin] pzygielo commented on pull request #23: [MINVOKER-254] Bump groovy to the latest in 2.4

Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #23:
URL: https://github.com/apache/maven-invoker-plugin/pull/23#issuecomment-662332913


   May I ask for review, please?
   <sup>(Marking as ready for review despite of failing github action for macOS/15-ea as it seems GHAs have some problems with installing JDKs today).</sup>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-invoker-plugin] pzygielo commented on pull request #23: [MINVOKER-254] Bump groovy to the latest in 2.4

Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #23:
URL: https://github.com/apache/maven-invoker-plugin/pull/23#issuecomment-662308695


   @slawekjaranowski @slachiewicz thanks for checking.
   
   I propose to upgrade already existing dependency only.
   
   I don't think it could block you as you'd need to deal with the same regardless of Groovy in version 2.4.19 or 2.4.20.
   
   In the upcoming release 3.2.2 there is only one `todo` issue, and it doesn't look like any revolution planned by you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-invoker-plugin] slachiewicz commented on pull request #23: [MINVOKER-254] Bump groovy to the latest in 2.4

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #23:
URL: https://github.com/apache/maven-invoker-plugin/pull/23#issuecomment-662292213


   I have plans to try upgrade to Groovy 2.5


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-invoker-plugin] asfgit closed pull request #23: [MINVOKER-254] Bump groovy to the latest in 2.4

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #23:
URL: https://github.com/apache/maven-invoker-plugin/pull/23


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org