You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 23:32:58 UTC

[GitHub] [airflow] potiuk commented on pull request #22502: Add timeout parameter to `DockerOperator`

potiuk commented on PR #22502:
URL: https://github.com/apache/airflow/pull/22502#issuecomment-1098574176

   I think `timeout` is not what you think it is. It's not well described in the docs (might be a good idea to add docstrings) :). - is a timeout for setting up the connection with Docker via HTTP.  You should take a look how it is passed to Hook and ClientAPI https://docker-py.readthedocs.io/en/1.1.0/api/ .
   
   What you really wanted there is "execution_timeout" from the BaseOperator: https://airflow.apache.org/docs/apache-airflow/1.10.6/_api/airflow/models/index.html#airflow.models.BaseOperator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org