[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3897: [ISSUE #3896] fix log format error

[GitBox <gi...@apache.org>]

XiaoyiPeng commented on a change in pull request #3897:
URL: https://github.com/apache/rocketmq/pull/3897#discussion_r816414912



##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
##########
@@ -621,7 +621,7 @@ private void onExceptionImpl(final String brokerName,
                 retryBrokerName = mqChosen.getBrokerName();
             }
             String addr = instance.findBrokerAddressInPublish(retryBrokerName);
-            log.warn(String.format("async send msg by retry {} times. topic={}, brokerAddr={}, brokerName={}", tmp, msg.getTopic(), addr,
+            log.warn(String.format("async send msg by retry %s times. topic=%s, brokerAddr=%s, brokerName=%s", tmp, msg.getTopic(), addr,

Review comment:
       Would it be better to format variable `tmp` with `%d`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org