You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/20 07:55:44 UTC

[PR] fix: bound ACL rule page sizes [rocketmq-dashboard]

tju-yxq opened a new pull request, #2439:
URL: https://github.com/apache/rocketmq-dashboard/pull/2439

   `GET /api/acl/rules` silently normalized invalid pagination values and accepted an arbitrarily large page size, while `GET /api/acl/users/page` rejects values outside `1..100`. This aligns the rule inventory with the user inventory contract:
   
   - reject `page < 1`, `pageSize < 1`, and `pageSize > 100` with 400 before repository or Tencent rule discovery
   - keep omitted values on the existing defaults (`page=1`, `pageSize=20`)
   - accept the full valid range up to 100
   - cover the Apache repository path, the pre-Tencent-discovery path, and the HTTP error envelope
   
   Verification:
   
   - focused: `mvn -Dtest=AclServiceTest,AclControllerTest test`
   - backend full suite: 1,484 tests passed, Checkstyle 0 violations
   - `git diff --check` passed
   
   Fixes #2438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: bound ACL rule page sizes [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #2439:
URL: https://github.com/apache/rocketmq-dashboard/pull/2439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org