You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/08/19 03:01:49 UTC
Review Request 37598: GEODE-229: Fixed javadoc for
DiskStoreFactory.setCompactionThreshold
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37598/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
The javadocs and the behavior of the code were backwards. The code
compacts when the live data gets below the threshold. I changed the
javadocs to avoid screwing up someone who was relied on the old
behavior.
Adding a unit test of this property.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/cache/DiskStoreFactory.java ab67c756c9c75fe91f040c7eee39f590ee9aceba
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegionJUnitTest.java bfc832a545fbcea5c5e21a8d15858ff93222e862
Diff: https://reviews.apache.org/r/37598/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 37598: GEODE-229: Fixed javadoc for
DiskStoreFactory.setCompactionThreshold
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37598/#review95892
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Aug. 18, 2015, 6:01 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37598/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 6:01 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The javadocs and the behavior of the code were backwards. The code
> compacts when the live data gets below the threshold. I changed the
> javadocs to avoid screwing up someone who was relied on the old
> behavior.
>
> Adding a unit test of this property.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/DiskStoreFactory.java ab67c756c9c75fe91f040c7eee39f590ee9aceba
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegionJUnitTest.java bfc832a545fbcea5c5e21a8d15858ff93222e862
>
> Diff: https://reviews.apache.org/r/37598/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 37598: GEODE-229: Fixed javadoc for
DiskStoreFactory.setCompactionThreshold
Posted by Ashvin A <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37598/#review95884
-----------------------------------------------------------
Ship it!
Ship It!
- Ashvin A
On Aug. 19, 2015, 1:01 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37598/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 1:01 a.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The javadocs and the behavior of the code were backwards. The code
> compacts when the live data gets below the threshold. I changed the
> javadocs to avoid screwing up someone who was relied on the old
> behavior.
>
> Adding a unit test of this property.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/DiskStoreFactory.java ab67c756c9c75fe91f040c7eee39f590ee9aceba
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegionJUnitTest.java bfc832a545fbcea5c5e21a8d15858ff93222e862
>
> Diff: https://reviews.apache.org/r/37598/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>