You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/06/15 07:38:01 UTC

[GitHub] [arrow] kou commented on issue #36065: [Python][Release] 12.0.1 has 12.0.0 metadata

kou commented on issue #36065:
URL: https://github.com/apache/arrow/issues/36065#issuecomment-1592521825

   You used `dev/release/03-binary-submit.sh`, right?
   
   It passes a branch name (`apache-arrow-12.0.1` in this case) to `archery crossbow submit` but each job does not use the branch name to checkout apache/arrow. See `dev/tasks/macros.jinja`. It uses `arrow.head` instead of `arrow.branch` (`apache-arrow-12.0.1` in this case).
   
   `arrow.head` is the revision of HEAD in the local repository. So I think that you run `dev/release/03-binary-submit.sh` on https://github.com/apache/arrow/commit/6af660f48472b8b45a5e01b7136b9b040b185eb1 .
   
   What should we do to prevent this in the future?
   
   1. Verify package version in `dev/release/verify-release-candidate.sh` too
   2. Use tag name to build binary artifacts
   
   ```diff
   diff --git a/dev/release/03-binary-submit.sh b/dev/release/03-binary-submit.sh
   index d65b4e97c..ca9da2052 100755
   --- a/dev/release/03-binary-submit.sh
   +++ b/dev/release/03-binary-submit.sh
   @@ -43,6 +43,7 @@ archery crossbow submit \
        --arrow-version ${version_with_rc} \
        --arrow-remote "https://github.com/${ARROW_REPOSITORY}" \
        --arrow-branch ${ARROW_BRANCH} \
   +    --arrow-sha ${ARROW_BRANCH} \
        --group packaging
    
    # archery will add a comment to the automatically generated PR to track
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org