You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Viraj Jasani (Jira)" <ji...@apache.org> on 2022/04/08 13:06:00 UTC

[jira] [Created] (HADOOP-18196) Remove replace-guava from replacer plugin

Viraj Jasani created HADOOP-18196:
-------------------------------------

             Summary: Remove replace-guava from replacer plugin
                 Key: HADOOP-18196
                 URL: https://issues.apache.org/jira/browse/HADOOP-18196
             Project: Hadoop Common
          Issue Type: Task
            Reporter: Viraj Jasani


While running the build, realized that all replacer plugin executions run only after "banned-illegal-imports" enforcer plugin.

For instance,
{code:java}
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-illegal-imports) @ hadoop-cloud-storage ---
[INFO] 
[INFO] --- replacer:1.5.3:replace (replace-generated-sources) @ hadoop-cloud-storage ---
[INFO] Skipping
[INFO] 
[INFO] --- replacer:1.5.3:replace (replace-sources) @ hadoop-cloud-storage ---
[INFO] Skipping
[INFO] 
[INFO] --- replacer:1.5.3:replace (replace-guava) @ hadoop-cloud-storage ---
[INFO] Replacement run on 0 file.
[INFO]  {code}
Hence, if our source code uses com.google.common, banned-illegal-imports will cause the build failure and replacer plugin would not even get executed.

We should remove it as it is only redundant execution step.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org