You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2025/06/02 15:12:50 UTC

Re: [PR] Disable metrics for thread pools when metrics disabled [accumulo]

dlmarion commented on code in PR #5605:
URL: https://github.com/apache/accumulo/pull/5605#discussion_r2121462812


##########
core/src/main/java/org/apache/accumulo/core/classloader/DefaultContextClassLoaderFactory.java:
##########
@@ -74,7 +74,7 @@ private static void setContextConfig(Supplier<Map<String,String>> contextConfigS
   private static void startCleanupThread(final AccumuloConfiguration conf,
       final Supplier<Map<String,String>> contextConfigSupplier) {
     ScheduledFuture<?> future =
-        ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools((t, e) -> {
+        ((ScheduledThreadPoolExecutor) ThreadPools.getClientThreadPools(conf, (t, e) -> {

Review Comment:
   This implements `org.apache.accumulo.core.spi.common.ContextClassLoaderFactory`, part of the SPI, so can't push down the context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org