You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2020/04/18 00:02:29 UTC
[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15751
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
......................................................................
IMPALA-9666 Correct a log message in TestImpalaShellInteractive
When _wait_for_num_open_sessions() calls wait_for_metric_value() and
wait_for_metric_value() hits an assertion error then
_wait_for_num_open_sessions() catches the exception and attempts to log
a descriptive string that was passed to it as a parameter. The logging
call does not have a '%s' directive, which results in the failure being
reported as
"TypeError: not all arguments converted during string formatting".
Fix this by adding the '%s' directive to the logging call.
Change-Id: Icfd7baed153dadceb953df30beba180128055c92
---
M tests/shell/test_shell_interactive.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/15751/1
--
To view, visit http://gerrit.cloudera.org:8080/15751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Gerrit-Change-Number: 15751
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15751 )
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/365/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Gerrit-Change-Number: 15751
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 16:30:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15751 )
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
......................................................................
IMPALA-9666 Correct a log message in TestImpalaShellInteractive
When _wait_for_num_open_sessions() calls wait_for_metric_value() and
wait_for_metric_value() hits an assertion error then
_wait_for_num_open_sessions() catches the exception and attempts to log
a descriptive string that was passed to it as a parameter. The logging
call does not have a '%s' directive, which results in the failure being
reported as
"TypeError: not all arguments converted during string formatting".
Fix this by adding the '%s' directive to the logging call.
Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Reviewed-on: http://gerrit.cloudera.org:8080/15751
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
0 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Gerrit-Change-Number: 15751
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15751 )
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Gerrit-Change-Number: 15751
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 16:30:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15751 )
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
......................................................................
Patch Set 1: Code-Review+2
THanks for fixing this
--
To view, visit http://gerrit.cloudera.org:8080/15751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Gerrit-Change-Number: 15751
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Apr 2020 04:19:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15751 )
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5822/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Gerrit-Change-Number: 15751
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Apr 2020 00:43:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15751 )
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Gerrit-Change-Number: 15751
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 16:38:49 +0000
Gerrit-HasComments: No