You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/02/20 22:20:45 UTC

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17639: Set Ninja build generator in config.cmake instead of commmand line

apeforest commented on a change in pull request #17639: Set Ninja build generator in config.cmake instead of commmand line
URL: https://github.com/apache/incubator-mxnet/pull/17639#discussion_r382290739
 
 

 ##########
 File path: docs/static_site/src/pages/get_started/osx_setup.md
 ##########
 @@ -110,13 +110,10 @@ the guide in [Math Library Selection](build_from_source#math-library-selection).
 ```bash
 rm -rf build
 mkdir -p build && cd build
-cmake -GNinja -C ../config.cmake ..
-cmake --build . --parallel 8
+cmake -C ../config.cmake ..
 
 Review comment:
   Is -C ../config.cmake required?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services