You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by benbenw <gi...@git.apache.org> on 2016/09/08 12:32:53 UTC
[GitHub] jmeter pull request #228: small memory improvement : do dot convert all the ...
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/228
small memory improvement : do dot convert all the url to check the
prefix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter small-perf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
commit f716f89e28aeab963a7a0f15c4b24927b475c7bf
Author: benoit <b....@ubik-ingenierie.com>
Date: 2016-09-08T12:32:00Z
small memory improvement : do dot convert all the url to check the
prefix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #228: small memory improvement : do dot convert all the url to ...
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/228
Looks good. Just one question: HOW did you find that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #228: small memory improvement : do dot convert all the url to ...
Posted by FSchumacher <gi...@git.apache.org>.
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/228
There is StringUtils#startsWithIgnoreCase, that does the same and is clearly named.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #228: small memory improvement : do dot convert all the ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #228: small memory improvement : do dot convert all the url to ...
Posted by sebbASF <gi...@git.apache.org>.
Github user sebbASF commented on the issue:
https://github.com/apache/jmeter/pull/228
It may be slightly more efficient to use regionMatches, but it's not nearly so obvious what the code is doing.
However checking log.isDebugEnabled() first is an improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---