You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2020/01/20 13:29:24 UTC

[GitHub] [griffin] XiaoyuBD opened a new pull request #567: [GRIFFIN-322] Add SQL mode for ES connector

XiaoyuBD opened a new pull request #567: [GRIFFIN-322] Add SQL mode for ES connector
URL: https://github.com/apache/griffin/pull/567
 
 
   As  [GRIFFIN-322](https://issues.apache.org/jira/projects/GRIFFIN/issues/GRIFFIN-322?filter=allopenissues) , we want add sql mode for es connector.   
   
   **The sql mode would more effective and user-friendly.** 
   
   Current mode config:
   {   "class": "org.apache.griffin.measure.datasource.connector.batch.ElasticSearchGriffinDataConnector",
       "index": "index-xxx",
       "type": "metric",
       "host": "xxxxxxxxxx",
       "port": "xxxx",
       "fields": ["col_a", "col_b", "col_c"],
       "size": 100}
   
   SQL mode config: 
   {    "class": "org.apache.griffin.measure.datasource.connector.batch.ElasticSearchGriffinDataConnector",
        "host": "xxxxxxxxxx",
        "port": "xxxx",
        "sql": "select col_a, col_b, col_c from index-xx limit 100"}
   
   Compared with current mode, SQL mode could support other types except number type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [griffin] wankunde commented on issue #567: [GRIFFIN-322] Add SQL mode for ES connector

Posted by GitBox <gi...@apache.org>.
wankunde commented on issue #567: [GRIFFIN-322] Add SQL mode for ES connector
URL: https://github.com/apache/griffin/pull/567#issuecomment-583714858
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [griffin] asfgit closed pull request #567: [GRIFFIN-322] Add SQL mode for ES connector

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #567: [GRIFFIN-322] Add SQL mode for ES connector
URL: https://github.com/apache/griffin/pull/567
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [griffin] XiaoyuBD commented on issue #567: [GRIFFIN-322] Add SQL mode for ES connector

Posted by GitBox <gi...@apache.org>.
XiaoyuBD commented on issue #567: [GRIFFIN-322] Add SQL mode for ES connector
URL: https://github.com/apache/griffin/pull/567#issuecomment-581208319
 
 
   Could you please check this PR? @wankunde  Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services