[jira] [Commented] (SPARK-11317) YARN HBase token code shouldn't swallow invocation target exceptions

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974905#comment-14974905 ] 

Steve Loughran commented on SPARK-11317:
----------------------------------------

I'll do this as soon as SPARK-11265 is in; I've factored the code there to make it straightforward.

This is actually a very important patch, because the current code *will not log any authentication problems*. All you get is an "invocation target exception" message in the log, which isn't enough to fix things

> YARN HBase token code shouldn't swallow invocation target exceptions
> --------------------------------------------------------------------
>
>                 Key: SPARK-11317
>                 URL: https://issues.apache.org/jira/browse/SPARK-11317
>             Project: Spark
>          Issue Type: Bug
>            Reporter: Steve Loughran
>
> As with SPARK-11265; the HBase token retrieval code of SPARK-6918
> 1. swallows exceptions it should be rethrowing as serious problems (e.g NoSuchMethodException)
> 1. Swallows any exception raised by the HBase client, without even logging the details (it logs that an `InvocationTargetException` was caught, but not the contents)
> As such it is potentially brittle to changes in the HDFS client code, and absolutely not going to provide any assistance if HBase won't actually issue tokens to the caller.
> The code in SPARK-11265 can be re-used to provide consistent and better exception processing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org