You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/03/27 17:36:39 UTC
[kudu-CR] [Java] Upgrade dependencies
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12869
Change subject: [Java] Upgrade dependencies
......................................................................
[Java] Upgrade dependencies
Upgrades the Java dependencies and Gradle versions.
Some rework of the Error Prone plugin configuration
was needed to get on a current version.
Major version upgrades:
- hamcrest 1.3 -> 2.1
Minor version upgrades:
- guava 27.0.1-jre -> 27.1-jre
- mockito 2.23.4 -> 2.25.1
- protobuf 3.6.1 -> 3.7.0
Maintenance version upgrades:
- osdetector 1.6.1 -> 1.6.2
- scalatest 3.0.5 -> 3.0.7
- slf4j 1.7.25 -> 1.7.26
Gradle upgrades:
- gradle 5.1.1 -> 5.3
- gradle-versions-plugin 0.20.0 -> 0.21.0
- shadow 4.0.4 -> 5.0.0
- nebula-clojure-plugin 8.0.0 -> 8.1.1
- spotbugs-gradle-plugin 1.6.9 -> 1.7.0
- gradle-errorprone-plugin 0.0.16 -> 0.7.1
Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/kudu-client/build.gradle
5 files changed, 40 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/12869/1
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Upgrade dependencies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12869/3/java/gradle/wrapper/gradle-wrapper.properties
File java/gradle/wrapper/gradle-wrapper.properties:
PS3:
Does this require a RAT update?
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Mar 2019 20:11:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Upgrade dependencies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle@36
PS1, Line 36: errorProneJavac: "9+181-r4173-1",
> The repo for it is here: https://github.com/google/error-prone-javac
Ah neat, javac written in Java. OK, makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Mar 2019 18:49:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Upgrade dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle@33
PS1, Line 33: // errorprone 2.3.2+ has an issue on older JDKs see
> May want to clarify that this is specifically about old JDK8 versions, so t
good point, we shouldn't need this anymore.
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle@36
PS1, Line 36: errorProneJavac: "9+181-r4173-1",
> So this is a full-fledged JDK of sorts? Is it a native dependency?
The repo for it is here: https://github.com/google/error-prone-javac
It looks like it's a a mirror of the OpenJDK langtools repository and it's not a native dep.
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Mar 2019 18:47:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Upgrade dependencies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle@33
PS1, Line 33: // errorprone 2.3.2+ has an issue on older JDKs see
May want to clarify that this is specifically about old JDK8 versions, so that if/when we drop JDK8 support we'll know this can be upgraded.
Or is this no longer an issue now that error prone is using its own javac?
http://gerrit.cloudera.org:8080/#/c/12869/1/java/gradle/dependencies.gradle@36
PS1, Line 36: errorProneJavac: "9+181-r4173-1",
So this is a full-fledged JDK of sorts? Is it a native dependency?
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Mar 2019 17:49:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Upgrade dependencies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Mar 2019 20:27:35 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Upgrade dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12869
to look at the new patch set (#3).
Change subject: [Java] Upgrade dependencies
......................................................................
[Java] Upgrade dependencies
Upgrades the Java dependencies and Gradle versions.
Some rework of the Error Prone plugin configuration
was needed to get on a current version.
Gradle now includes a license in the wrapper script
so the custom license injection was removed.
I also removed it from the properties file, since it’s
configuration data rather than code and simple enough
that it would count as a non-copyrightable statement of facts.
Major version upgrades:
- hamcrest 1.3 -> 2.1
Minor version upgrades:
- guava 27.0.1-jre -> 27.1-jre
- mockito 2.23.4 -> 2.25.1
- protobuf 3.6.1 -> 3.7.0
Maintenance version upgrades:
- osdetector 1.6.1 -> 1.6.2
- scalatest 3.0.5 -> 3.0.7
- slf4j 1.7.25 -> 1.7.26
Gradle upgrades:
- gradle 5.1.1 -> 5.3.1
- gradle-versions-plugin 0.20.0 -> 0.21.0
- shadow 4.0.4 -> 5.0.0
- nebula-clojure-plugin 8.0.0 -> 8.1.1
- spotbugs-gradle-plugin 1.6.9 -> 1.7.0
- gradle-errorprone-plugin 0.0.16 -> 0.7.1
Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/kudu-client/build.gradle
7 files changed, 46 insertions(+), 94 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/12869/3
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Upgrade dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies
......................................................................
[Java] Upgrade dependencies
Upgrades the Java dependencies and Gradle versions.
Some rework of the Error Prone plugin configuration
was needed to get on a current version.
Gradle now includes a license in the wrapper script
so the custom license injection was removed.
I also removed it from the properties file, since it’s
configuration data rather than code and simple enough
that it would count as a non-copyrightable statement of facts.
Major version upgrades:
- hamcrest 1.3 -> 2.1
Minor version upgrades:
- guava 27.0.1-jre -> 27.1-jre
- mockito 2.23.4 -> 2.25.1
- protobuf 3.6.1 -> 3.7.0
Maintenance version upgrades:
- osdetector 1.6.1 -> 1.6.2
- scalatest 3.0.5 -> 3.0.7
- slf4j 1.7.25 -> 1.7.26
Gradle upgrades:
- gradle 5.1.1 -> 5.3.1
- gradle-versions-plugin 0.20.0 -> 0.21.0
- shadow 4.0.4 -> 5.0.0
- nebula-clojure-plugin 8.0.0 -> 8.1.1
- spotbugs-gradle-plugin 1.6.9 -> 1.7.0
- gradle-errorprone-plugin 0.0.16 -> 0.7.1
Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Reviewed-on: http://gerrit.cloudera.org:8080/12869
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/release/rat_exclude_files.txt
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/kudu-client/build.gradle
8 files changed, 47 insertions(+), 94 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Upgrade dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12869
to look at the new patch set (#2).
Change subject: [Java] Upgrade dependencies
......................................................................
[Java] Upgrade dependencies
Upgrades the Java dependencies and Gradle versions.
Some rework of the Error Prone plugin configuration
was needed to get on a current version.
Major version upgrades:
- hamcrest 1.3 -> 2.1
Minor version upgrades:
- guava 27.0.1-jre -> 27.1-jre
- mockito 2.23.4 -> 2.25.1
- protobuf 3.6.1 -> 3.7.0
Maintenance version upgrades:
- osdetector 1.6.1 -> 1.6.2
- scalatest 3.0.5 -> 3.0.7
- slf4j 1.7.25 -> 1.7.26
Gradle upgrades:
- gradle 5.1.1 -> 5.3
- gradle-versions-plugin 0.20.0 -> 0.21.0
- shadow 4.0.4 -> 5.0.0
- nebula-clojure-plugin 8.0.0 -> 8.1.1
- spotbugs-gradle-plugin 1.6.9 -> 1.7.0
- gradle-errorprone-plugin 0.0.16 -> 0.7.1
Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/kudu-client/build.gradle
5 files changed, 40 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/12869/2
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Upgrade dependencies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12869 )
Change subject: [Java] Upgrade dependencies
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Mar 2019 21:41:19 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Upgrade dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12869
to look at the new patch set (#4).
Change subject: [Java] Upgrade dependencies
......................................................................
[Java] Upgrade dependencies
Upgrades the Java dependencies and Gradle versions.
Some rework of the Error Prone plugin configuration
was needed to get on a current version.
Gradle now includes a license in the wrapper script
so the custom license injection was removed.
I also removed it from the properties file, since it’s
configuration data rather than code and simple enough
that it would count as a non-copyrightable statement of facts.
Major version upgrades:
- hamcrest 1.3 -> 2.1
Minor version upgrades:
- guava 27.0.1-jre -> 27.1-jre
- mockito 2.23.4 -> 2.25.1
- protobuf 3.6.1 -> 3.7.0
Maintenance version upgrades:
- osdetector 1.6.1 -> 1.6.2
- scalatest 3.0.5 -> 3.0.7
- slf4j 1.7.25 -> 1.7.26
Gradle upgrades:
- gradle 5.1.1 -> 5.3.1
- gradle-versions-plugin 0.20.0 -> 0.21.0
- shadow 4.0.4 -> 5.0.0
- nebula-clojure-plugin 8.0.0 -> 8.1.1
- spotbugs-gradle-plugin 1.6.9 -> 1.7.0
- gradle-errorprone-plugin 0.0.16 -> 0.7.1
Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
---
M build-support/release/rat_exclude_files.txt
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/kudu-client/build.gradle
8 files changed, 47 insertions(+), 94 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/12869/4
--
To view, visit http://gerrit.cloudera.org:8080/12869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I25d73cfa715c7a5ed1d572b3d3a8f63607f0fed2
Gerrit-Change-Number: 12869
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)