You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jeremy Boynes <jb...@apache.org> on 2005/09/21 02:47:02 UTC
Re: svn commit: r290538 - /geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
What about statistics?
--
Jeremy
djencks@apache.org wrote:
> Author: djencks
> Date: Tue Sep 20 12:26:46 2005
> New Revision: 290538
>
> URL: http://svn.apache.org/viewcvs?rev=290538&view=rev
> Log:
> GERONIMO-1003 non-persistent attributes cannot be manageable
>
> Modified:
> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
>
> Modified: geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
> URL: http://svn.apache.org/viewcvs/geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java?rev=290538&r1=290537&r2=290538&view=diff
> ==============================================================================
> --- geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java (original)
> +++ geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java Tue Sep 20 12:26:46 2005
> @@ -75,7 +75,8 @@
> this.name = name;
> this.type = type;
> this.persistent = persistent;
> - this.manageable = manageable;
> + //non persistent attributes cannot be manageable
> + this.manageable = manageable & persistent;
> this.readable = readable;
> this.writable = writable;
> this.getterName = getterName;
>
>
Re: svn commit: r290538 - /geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
Remember that statistics shouldn't be in the GBeans anyway. I think the
JVMImpl is the only one that does this correctly. The GBean should cough up
a Stats object (like JVMStats or EJBStats or whatever) that contains a bunch
of Statistics properties. So the only method on the GBean is the "getStats".
I have a huge todo list of all the Stats stuff we need to implement properly
on the Wiki on the page http://wiki.apache.org/geronimo/Web_Console
Also, our definition of "manageable" is not "only manageable properties
appear in the management API" but "only manageable properties can be changed
in the management API". You know, even if you've locked down certain
properties, I think the admin should be able to *see* their values.
Aaron
On 9/20/05, Jeremy Boynes <jb...@apache.org> wrote:
>
> David Jencks wrote:
> > Can you explain how saving statistics values between server stop/starts
> > is meaningful? Could be, but I don't understand how yet. I basically
> > don't know anything about how people gather server statistics.
> >
> > Maybe calling this "manageable" is not quite the right term?
> >
>
> Obviously they aren't persistent, but they do need to be managed
> otherwise they are not viewable.
>
> I think there are three things here:
> * persistent - value can be saved in the bundle
> * configurable - value can in overridden by attribute store
> (implies persistent)
> * managed - value should be exposed to management (e.g. JMX)
>
> For example:
> * Statistics are managed but not persistent.
> * Config properties are configurable and probably managed.
> * Interceptor stacks are persistent but not configurable or managed.
> * Runtime properties (e.g. $resource) are none.
>
> --
> Jeremy
>
Re: svn commit: r290538 - /geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
Posted by Jeremy Boynes <jb...@apache.org>.
David Jencks wrote:
> Can you explain how saving statistics values between server stop/starts
> is meaningful? Could be, but I don't understand how yet. I basically
> don't know anything about how people gather server statistics.
>
> Maybe calling this "manageable" is not quite the right term?
>
Obviously they aren't persistent, but they do need to be managed
otherwise they are not viewable.
I think there are three things here:
* persistent - value can be saved in the bundle
* configurable - value can in overridden by attribute store
(implies persistent)
* managed - value should be exposed to management (e.g. JMX)
For example:
* Statistics are managed but not persistent.
* Config properties are configurable and probably managed.
* Interceptor stacks are persistent but not configurable or managed.
* Runtime properties (e.g. $resource) are none.
--
Jeremy
Re: svn commit: r290538 - /geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
And in any case manageable attributes are meant for users to be be able to
override in config.xml. I don't understand why users would want to override
statistics in that way.
Aaron
On 9/20/05, David Jencks <da...@yahoo.com> wrote:
>
> Can you explain how saving statistics values between server stop/starts
> is meaningful? Could be, but I don't understand how yet. I basically
> don't know anything about how people gather server statistics.
>
> Maybe calling this "manageable" is not quite the right term?
>
> thanks
> david jencks
>
> On Sep 20, 2005, at 8:47 PM, Jeremy Boynes wrote:
>
> > What about statistics?
> > --
> > Jeremy
> >
> > djencks@apache.org wrote:
> >> Author: djencks
> >> Date: Tue Sep 20 12:26:46 2005
> >> New Revision: 290538
> >> URL: http://svn.apache.org/viewcvs?rev=290538&view=rev
> >> Log:
> >> GERONIMO-1003 non-persistent attributes cannot be manageable
> >> Modified:
> >>
> >> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
> >> GAttributeInfo.java
> >> Modified:
> >> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
> >> GAttributeInfo.java
> >> URL:
> >> http://svn.apache.org/viewcvs/geronimo/trunk/modules/kernel/src/java/
> >> org/apache/geronimo/gbean/GAttributeInfo.java?
> >> rev=290538&r1=290537&r2=290538&view=diff
> >> ======================================================================
> >> ========
> >> ---
> >> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
> >> GAttributeInfo.java (original)
> >> +++
> >> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
> >> GAttributeInfo.java Tue Sep 20 12:26:46 2005
> >> @@ -75,7 +75,8 @@
> >> this.name <http://this.name> = name;
> >> this.type = type;
> >> this.persistent = persistent;
> >> - this.manageable = manageable;
> >> + //non persistent attributes cannot be manageable
> >> + this.manageable = manageable & persistent;
> >> this.readable = readable;
> >> this.writable = writable;
> >> this.getterName = getterName;
> >
>
>
Re: svn commit: r290538 - /geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/GAttributeInfo.java
Posted by David Jencks <da...@yahoo.com>.
Can you explain how saving statistics values between server stop/starts
is meaningful? Could be, but I don't understand how yet. I basically
don't know anything about how people gather server statistics.
Maybe calling this "manageable" is not quite the right term?
thanks
david jencks
On Sep 20, 2005, at 8:47 PM, Jeremy Boynes wrote:
> What about statistics?
> --
> Jeremy
>
> djencks@apache.org wrote:
>> Author: djencks
>> Date: Tue Sep 20 12:26:46 2005
>> New Revision: 290538
>> URL: http://svn.apache.org/viewcvs?rev=290538&view=rev
>> Log:
>> GERONIMO-1003 non-persistent attributes cannot be manageable
>> Modified:
>>
>> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
>> GAttributeInfo.java
>> Modified:
>> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
>> GAttributeInfo.java
>> URL:
>> http://svn.apache.org/viewcvs/geronimo/trunk/modules/kernel/src/java/
>> org/apache/geronimo/gbean/GAttributeInfo.java?
>> rev=290538&r1=290537&r2=290538&view=diff
>> ======================================================================
>> ========
>> ---
>> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
>> GAttributeInfo.java (original)
>> +++
>> geronimo/trunk/modules/kernel/src/java/org/apache/geronimo/gbean/
>> GAttributeInfo.java Tue Sep 20 12:26:46 2005
>> @@ -75,7 +75,8 @@
>> this.name = name;
>> this.type = type;
>> this.persistent = persistent;
>> - this.manageable = manageable;
>> + //non persistent attributes cannot be manageable
>> + this.manageable = manageable & persistent;
>> this.readable = readable;
>> this.writable = writable;
>> this.getterName = getterName;
>