You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/11 21:04:32 UTC

[GitHub] [airflow] davlum edited a comment on issue #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file

davlum edited a comment on issue #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#issuecomment-573354037
 
 
   Adding an additional argument won't break backwards compatibility, but it will change some of the previously required arguments to optional, which is a backwards compatible change. I'm open to the separate operator. I'm noticing there is some validation for the fields on the `KubernetesPodOperator` that wouldn't be necessary if `pod_template_file` is passed, so that might motivate a separate operator.  Would I also move the `full_pod_spec` arg to that operator as well?
   
   For the `executor_config`, should I add support for passing the `PodGenerator` directly in this PR, or make a ticket and new PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services