You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by gradywang <gi...@git.apache.org> on 2016/09/19 23:31:08 UTC
[GitHub] mesos pull request #168: Update contributors.yaml for gradywang.
GitHub user gradywang opened a pull request:
https://github.com/apache/mesos/pull/168
Update contributors.yaml for gradywang.
Update contributors.yaml for gradywang.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gradywang/mesos master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mesos/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #168: Update contributors.yaml for gradywang.
Posted by gradywang <gi...@git.apache.org>.
Github user gradywang commented on a diff in the pull request:
https://github.com/apache/mesos/pull/168#discussion_r79523013
--- Diff: docs/contributors.yaml ---
@@ -402,13 +402,13 @@
jira_user: yanyanhu
reviewboard_user: yanyanhu
-- name: Yong Qiao Wang
+- name: Yongqiao Wang
affiliations:
- - {organization: IBM}
--- End diff --
Thank @vinodkone, I have fixed by your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #168: Update contributors.yaml for gradywang.
Posted by vinodkone <gi...@git.apache.org>.
Github user vinodkone commented on a diff in the pull request:
https://github.com/apache/mesos/pull/168#discussion_r82063596
--- Diff: docs/contributors.yaml ---
@@ -402,13 +402,14 @@
jira_user: yanyanhu
reviewboard_user: yanyanhu
-- name: Yong Qiao Wang
--- End diff --
oh ok. then a single entry sounds fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #168: Update contributors.yaml for gradywang.
Posted by vinodkone <gi...@git.apache.org>.
Github user vinodkone commented on a diff in the pull request:
https://github.com/apache/mesos/pull/168#discussion_r79516117
--- Diff: docs/contributors.yaml ---
@@ -402,13 +402,13 @@
jira_user: yanyanhu
reviewboard_user: yanyanhu
-- name: Yong Qiao Wang
+- name: Yongqiao Wang
affiliations:
- - {organization: IBM}
--- End diff --
Instead of removing your old affiliation (IBM) completely, can you add an "end_date" to it? That way your contributions while you were employed at IBM, will be attributed correctly. See my affiliation above for an example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #168: Update contributors.yaml for gradywang.
Posted by gradywang <gi...@git.apache.org>.
Github user gradywang commented on a diff in the pull request:
https://github.com/apache/mesos/pull/168#discussion_r81929327
--- Diff: docs/contributors.yaml ---
@@ -402,13 +402,14 @@
jira_user: yanyanhu
reviewboard_user: yanyanhu
-- name: Yong Qiao Wang
--- End diff --
@vinodkone I also used `gradywang` as my reviewboard username rather than `JamesYongQiaoWang` when I in IBM in main contributions. For my name, it does not changed, and just change to the recommended format. So can I only change the old entry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #168: Update contributors.yaml for gradywang.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/mesos/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos issue #168: Update contributors.yaml for gradywang.
Posted by gradywang <gi...@git.apache.org>.
Github user gradywang commented on the issue:
https://github.com/apache/mesos/pull/168
@vinodkone, cloud you help to review this again? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] mesos pull request #168: Update contributors.yaml for gradywang.
Posted by vinodkone <gi...@git.apache.org>.
Github user vinodkone commented on a diff in the pull request:
https://github.com/apache/mesos/pull/168#discussion_r81236751
--- Diff: docs/contributors.yaml ---
@@ -402,13 +402,14 @@
jira_user: yanyanhu
reviewboard_user: yanyanhu
-- name: Yong Qiao Wang
--- End diff --
If your name and reviewboard username have also changed along with your affiliation, then it's probably worth to have two different entries in the YAML file.
```
- name: Yong Qiao Wang
affiliations:
- {organization: IBM}
emails:
- yqwyq@cn.ibm.com
jira_user: gradywang
reviewboard_user: JamesYongQiaoWang
- name: Yongqiao Wang
affiliations:
- {organization: Huawei}
emails:
- grady.wang@foxmail.com
jira_user: gradywang
reviewboard_user: gradywang
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---