[jira] [Updated] (DIRMINA-886) isBrokenConnection

["Emmanuel Lécharny (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRMINA-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lécharny updated DIRMINA-886:
--------------------------------------
    Description: 
class  :org.apache.mina.transport.socket.nio.NioProcessor 
Method：

{code:java}
protected boolean isBrokenConnection() throws IOException 
  /**
     * {@inheritDoc}
     */
    @Override
    protected boolean isBrokenConnection() throws IOException {
        // A flag set to true if we find a broken session
        boolean brokenSession = false;
        synchronized (selector) {
            // Get the selector keys
            Set<SelectionKey> keys = selector.keys();
            // Loop on all the keys to see if one of them
            // has a closed channel
            for (SelectionKey key : keys) {
                SelectableChannel channel = key.channel();
                if (((channel instanceof DatagramChannel) && ((DatagramChannel) channel)
                        .isConnected())
                        || ((channel instanceof SocketChannel) && ((SocketChannel) channel)
                                .isConnected())) {
                    // The channel is not connected anymore. Cancel
                    // the associated key then.
                    key.cancel();
                    // Set the flag to true to avoid a selector switch
                    brokenSession = true;
                }
            }
        }
        return brokenSession;
    }
 
{code}
--------------------------------------------------------------------------------

Question: if is need to add ! before ?


  was:
class  :org.apache.mina.transport.socket.nio.NioProcessor 
Method：protected boolean isBrokenConnection() throws IOException 
  /**
     * {@inheritDoc}
     */
    @Override
    protected boolean isBrokenConnection() throws IOException {
        // A flag set to true if we find a broken session
        boolean brokenSession = false;
        synchronized (selector) {
            // Get the selector keys
            Set<SelectionKey> keys = selector.keys();
            // Loop on all the keys to see if one of them
            // has a closed channel
            for (SelectionKey key : keys) {
                SelectableChannel channel = key.channel();
                if (((channel instanceof DatagramChannel) && ((DatagramChannel) channel)
                        .isConnected())
                        || ((channel instanceof SocketChannel) && ((SocketChannel) channel)
                                .isConnected())) {
                    // The channel is not connected anymore. Cancel
                    // the associated key then.
                    key.cancel();
                    // Set the flag to true to avoid a selector switch
                    brokenSession = true;
                }
            }
        }
        return brokenSession;
    }
 

--------------------------------------------------------------------------------

Question: if is need to add ! before ?



> isBrokenConnection
> ------------------
>
>                 Key: DIRMINA-886
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-886
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.4
>            Reporter: jinkai mao
>            Priority: Minor
>              Labels: isBrokenConnection
>             Fix For: 2.0.5
>
>
> class  :org.apache.mina.transport.socket.nio.NioProcessor 
> Method：
> {code:java}
> protected boolean isBrokenConnection() throws IOException 
>   /**
>      * {@inheritDoc}
>      */
>     @Override
>     protected boolean isBrokenConnection() throws IOException {
>         // A flag set to true if we find a broken session
>         boolean brokenSession = false;
>         synchronized (selector) {
>             // Get the selector keys
>             Set<SelectionKey> keys = selector.keys();
>             // Loop on all the keys to see if one of them
>             // has a closed channel
>             for (SelectionKey key : keys) {
>                 SelectableChannel channel = key.channel();
>                 if (((channel instanceof DatagramChannel) && ((DatagramChannel) channel)
>                         .isConnected())
>                         || ((channel instanceof SocketChannel) && ((SocketChannel) channel)
>                                 .isConnected())) {
>                     // The channel is not connected anymore. Cancel
>                     // the associated key then.
>                     key.cancel();
>                     // Set the flag to true to avoid a selector switch
>                     brokenSession = true;
>                 }
>             }
>         }
>         return brokenSession;
>     }
>  
> {code}
> --------------------------------------------------------------------------------
> Question: if is need to add ! before ?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org