You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "Lars Francke (Jira)" <ji...@apache.org> on 2020/02/19 16:22:00 UTC
[jira] [Comment Edited] (RANGER-2733) Enable Indentation and
FileTabCharacter Checkstyle plugin rules
[ https://issues.apache.org/jira/browse/RANGER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040193#comment-17040193 ]
Lars Francke edited comment on RANGER-2733 at 2/19/20 4:21 PM:
---------------------------------------------------------------
Probably worth mentioning that this patch not only enables the rules but also changes all existing files around. Not sure if that's a good idea.
Maybe it'd be easier to change the Checkstyle plugin to emit warnings instead of failing the build for a while.
But I certainly don't object either.
Could you maybe post your actual non-whitespace _changes_ separately so a review is possible?
was (Author: lars_francke):
Probably worth mentioning that this patch not only enables the rules but also changes all existing files around. Not sure if that's a good idea.
Maybe it'd be easier to change the Checkstyle plugin to emit warnings instead of failing the build for a while.
But I certainly don't object either.
Could you maybe post your actual _changes_ separately so a review is possible?
> Enable Indentation and FileTabCharacter Checkstyle plugin rules
> ---------------------------------------------------------------
>
> Key: RANGER-2733
> URL: https://issues.apache.org/jira/browse/RANGER-2733
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
> Affects Versions: 2.1.0
> Reporter: Pradeep Agrawal
> Assignee: Pradeep Agrawal
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: 0001-RANGER-2733-Enable-Indentation-and-FileTabCharacter-.patch
>
>
> I am proposing the idea of enabling these rules.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)