[GitHub] [iceberg] SinghAsDev commented on a diff in pull request #5036: Fix concurrent transactions overwriting commits by adding hive lock heartbeats.

[GitBox <gi...@apache.org>]

SinghAsDev commented on code in PR #5036:
URL: https://github.com/apache/iceberg/pull/5036#discussion_r923981928


##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommitLocks.java:
##########
@@ -248,4 +260,15 @@ public void testTableLevelProcessLockBlocksConcurrentHMSRequestsForSameTable() t
     // all threads eventually got their turn
     verify(spyClient, times(numConcurrentCommits)).lock(any(LockRequest.class));
   }
+
+  @Test
+  public void testLockHeartbeat() throws TException {

Review Comment:
   Added one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org