You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/03 16:09:18 UTC
[GitHub] [zookeeper] belugabehr opened a new pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
belugabehr opened a new pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr closed pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg closed pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
Posted by GitBox <gi...@apache.org>.
ztzg closed pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215#issuecomment-721301621
@anmolnar Please review once more. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215#issuecomment-722272667
Now in `master`. Thank you, @belugabehr (& reviewers)!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215#issuecomment-721595094
> LGTM. Good point by @ctubbsii, but I would also hope that nobody relies on `hashCode` stability across multiple iterations—and hope not to learn a lesson!
I agree... no users should be relying on that. My main concern was how it might be used within the project, that could affect something like client-server compatibility across different versions. If the jute-generated code does not use hash code for anything like that within the project, I agree it should be fine. I just don't know enough about how it is used. :smiley_cat: I raised the question, not knowing the answer, and you answered. So, this change looks good to me. :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr edited a comment on pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
Posted by GitBox <gi...@apache.org>.
belugabehr edited a comment on pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215#issuecomment-721313262
@ctubbsii Fair. This change does introduce a change in how hash codes are calculated, but the risk is very low. Unless someone is explicitly serializing these calculated hash values (the classes are not marked as Serializable) and writing them out to some sort of external storage, then I don't see how this would matter. Certainly does not impact anyone using ZK API directly. If someone is doing something this strange, doesn't mean they need to be supported in relying on this undocumented behavior (hash calculation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] belugabehr commented on pull request #1215: ZOOKEEPER-3687: Jute Use JDK hashCode Methods for Native Types
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1215:
URL: https://github.com/apache/zookeeper/pull/1215#issuecomment-721313262
@ctubbsii Fair. This change does introduce a change in how hash codes are calculated, but the risk is very low. Unless someone is explicitly serializing these values (the classes are not marked as Serializable) and writing them out to some sort of external storage, then I don't see how this would matter. Certainly does not impact anyone using ZK API directly. If someone is doing something this strange, doesn't mean they need to be supported in relying on this undocumented behavior (hash calculation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org