You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/16 22:41:21 UTC
[GitHub] [incubator-druid] jihoonson commented on issue #8328: [DISCUSS]
Code generation for commonly implemented basic methods
jihoonson commented on issue #8328: [DISCUSS] Code generation for commonly implemented basic methods
URL: https://github.com/apache/incubator-druid/issues/8328#issuecomment-522172692
@ccaominh @clintropolis thank you for the comments.
> I'm thinking of [things like this](https://github.com/apache/incubator-druid/pull/6488/files#diff-804f39ab6702c58b3d422f90625fee48R225) where a large or expensive to work with field is left out of all of those things on purpose.
This is a very good point. I guess this could be one of the reasons why we should change only a few classes per PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org