You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/15 17:47:47 UTC
[GitHub] [airflow] potiuk opened a new pull request #20889: Uses CI images built in previouse step to prepare PROD image
potiuk opened a new pull request #20889:
URL: https://github.com/apache/airflow/pull/20889
PROD image building needs CI images in order to prepare provider
packages needed to build PROD images. Those were taken from
the "latest" image but should be taken from the CI image built
in the previous step - the GITHUB_REGISTRY_PULL_IMAGE_TAG was
pointing to latest. This was not a problem in vast majority of
cases (it could only be problem if new dependencies were added
which would break validation of dependencies in the CI image)
or when you tried to push a change to the `main` branch in
forked image and you never pushed a latest CI image there).
This change sets GITHUB_REGISTRY_PULL_IMAGE_TAG to be the
same as just used GITHUB_REGISTRY_PUSH_IMAGE_TAG to push the
CI images - so it will always pull the CI images pushed in the
previous job.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20889: Uses CI images built in previous step to prepare PROD image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20889:
URL: https://github.com/apache/airflow/pull/20889#issuecomment-1015051790
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20889: Uses CI images built in previouse step to prepare PROD image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20889:
URL: https://github.com/apache/airflow/pull/20889#issuecomment-1013724222
cc: @edithturn - this was the bug you discovered why testing #20701 in your fork. Good catch !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20889: Uses CI images built in previouse step to prepare PROD image
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20889:
URL: https://github.com/apache/airflow/pull/20889#issuecomment-1014931285
@ashb @uranusjr @ephraimbuddy @mik-laj - this one needs to be merged to fix PROD build in #20910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #20889: Uses CI images built in previous step to prepare PROD image
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #20889:
URL: https://github.com/apache/airflow/pull/20889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org