You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/02 18:20:00 UTC
[jira] [Commented] (CB-14061) cordova-plugin-inappbrowser should
allow more custom URL schemes
[ https://issues.apache.org/jira/browse/CB-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461451#comment-16461451 ]
ASF GitHub Bot commented on CB-14061:
-------------------------------------
timbru31 opened a new pull request #269: fix(CB-14061): comply with RFC 3986 for custom URL scheme handling
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/269
### Platforms affected
Android
### What does this PR do?
This fixes a small regression of #263 to allow more custom URL schemes for android (see comment https://github.com/apache/cordova-plugin-inappbrowser/pull/263#issuecomment-386063556)
### What testing has been done on this change?
Manual testing with a custom URL scheme: `staging+d2d`
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> cordova-plugin-inappbrowser should allow more custom URL schemes
> ----------------------------------------------------------------
>
> Key: CB-14061
> URL: https://issues.apache.org/jira/browse/CB-14061
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Affects Versions: 3.0.0
> Reporter: Tim Brust
> Priority: Minor
>
> The current Android regexp (^[a-z]*://.*?$) (https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L1115) does not allow schemes like d2d or develop+d2d.
> According to RFC 3986 (quoting) "Scheme names consist of a sequence of characters beginning with a letter and followed by any combination of letters, digits, plus ("+"), period ("."), or hyphen ("-")" (https://tools.ietf.org/html/rfc3986#section-3.1)
>
> The regexp should be expanded to allow numbers, plus, periods and hyphens.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org