You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2012/08/14 18:44:37 UTC
[jira] [Created] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Jun Rao created KAFKA-458:
-----------------------------
Summary: remove errorcode from ByteBufferMessageSet
Key: KAFKA-458
URL: https://issues.apache.org/jira/browse/KAFKA-458
Project: Kafka
Issue Type: Sub-task
Components: core
Affects Versions: 0.8
Reporter: Jun Rao
Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao closed KAFKA-458.
-------------------------
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch, kafka-458-v3.patch, kafka-458-v4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-458:
--------------------------------
Attachment: kafka-458-v1.patch
There was a method to calculate hashcode in ByteBufferMessageSet, but it was never used. So I have removed it. Also removed the method hasError in KafkaETLContext.java as it was not used anymore.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike reassigned KAFKA-458:
-----------------------------------
Assignee: Swapnil Ghike
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452133#comment-13452133 ]
Jun Rao commented on KAFKA-458:
-------------------------------
Thanks for patch v3. Some comments:
1. Could you rebase?
2. javaapi.ByteBufferMessageSet.hash(): should we just call the underlying hashcode?
3. KafkaApis.readMessageSet(fetchRequest): Could you fix the indentation of try/catch?
4. PartitionTopicInfo.enqueueError can be removed since it's no longer used.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch, kafka-458-v3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-458:
--------------------------------
Attachment: kafka-458-v4.patch
Modified the patch.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch, kafka-458-v3.patch, kafka-458-v4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Joel Koshy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Koshy updated KAFKA-458:
-----------------------------
Labels: optimization (was: )
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: optimization
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437240#comment-13437240 ]
Jun Rao commented on KAFKA-458:
-------------------------------
Thanks for patch v1. You only fixed the ByteBufferMessageSet in javaapi. There is another ByteBufferMessageSet in kafka.messsage that needs to be fixed. Also, in ByteBufferMessageSet, we should get rid of those get* methods and use the val directly.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449045#comment-13449045 ]
Jay Kreps commented on KAFKA-458:
---------------------------------
Swapnil, this patch look fantastic, very thorough clean up. One issue: in ByteBufferMessageSet you leave equals() overridden but I think hashCode is no longer overridden (basically the equals uses the initial offset but the hash code doesn't). This can cause some subtle issues with use of collections, and is probably a bug.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-458:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for patch v4. Committed to 0.8.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch, kafka-458-v3.patch, kafka-458-v4.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-458:
--------------------------------
Attachment: kafka-458-v2.patch
Changes from last patch:
1. Removed errorcode from message/ByteBufferMessageSet.
2. Modified 4 unit tests to check for errorcode in FetchResponse.data(i).partitionDataArray(j).error
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449011#comment-13449011 ]
Jay Kreps commented on KAFKA-458:
---------------------------------
Jun, what would this serialized api be for? ByteBufferMessageSet already has a buffer field which has the serialized ByteBuffer. Other message sets can be copied to a ByteBufferMessageSet if desired, do we need a new api in the interface? I recommend we just add the @BeanProperty to the existing buffer field.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447786#comment-13447786 ]
Jun Rao commented on KAFKA-458:
-------------------------------
Thanks for patch v2. Some comments:
1. ByteBufferMessageSet: To be consistent btw the java and the scala version, we should have a public api serialized() to get the serialized byteBuffer and make buffer a private field. Also, the javaapi version needs to define hashCode since it may be used in a map.
2. ByteBufferMessageSet, KafkaETLContext: remove unused imports.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449056#comment-13449056 ]
Jay Kreps commented on KAFKA-458:
---------------------------------
Also, I think KafkaApis.readMessageSet should no longer catch the the exception and return an Either[Short,MessageSet] I think. This was a bit of a hack and makes the code in KafkaApis.readMessageSets a little hard to read (i.e. the reference to left and right would be more clear as a try/catch since that is what it is).
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-458:
--------------------------------
Attachment: kafka-458-v3.patch
2.1 As discussed with Jun, since any use of javaapi/ByteBufferMessageSet must happen through the iterator, I have removed the getSerialized() method and made the buffer field private. The buffer field in non javaapi version of ByteBufferMessageSet is a public val. The getSerialized() method is removed from non javaapi version of ByteBufferMessageSet, MessageSet and FileMessageSet as well (where it merely threw an UnsupportedOperationException). This introduces a need for a typecast in ProducerRequest.writeTo(buffer) and it perhaps could look like another hack introduced to get rid of the UnsupportedOperationException hack in FileMessageSet. This could be taken care of with KAFKA-289.
2.2. Removed unused imports.
2.3 The hashCode method is now overridden. Jay, thanks for catching that!
2.4 Just to be sure, did you mean that the behaviour achieved by Either should be achieved by throwing an exception in KafkaApis.readMessageSet and catching it in KafkaApis.readMessageSets? That's what I have done in this patch.
2.5 Removed testValidBytes() in javaapi/ByteBufferMessageSetTest because it was merely running the test on underlying.validBytes and there is already another test that does the same thing on non javaapi version of ByteBufferMessageSet. Moved testValidBytesWithCompression() from javaapi/ByteBufferMessageSetTest to the other ByteBufferMessageSetTest.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch, kafka-458-v3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-458:
--------------------------------
Fix Version/s: 0.8
Status: Patch Available (was: In Progress)
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KAFKA-458 started by Swapnil Ghike.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-458) remove errorcode from
ByteBufferMessageSet
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449116#comment-13449116 ]
Jun Rao commented on KAFKA-458:
-------------------------------
Jay, we just need a consistent api to get the byteBuffer in the scala and the java version of ByteBufferMessageSet. @BeanProperty probably works too.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira