You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/10 21:22:14 UTC
[GitHub] [arrow] westonpace commented on a change in pull request #11130: ARROW-12087: [C++] Allow sorting durations, timestamps with timezones
westonpace commented on a change in pull request #11130:
URL: https://github.com/apache/arrow/pull/11130#discussion_r706477733
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -651,6 +651,11 @@ void AddSortingKernels(VectorKernel base, VectorFunction* func) {
base.exec = ExecTemplate<UInt64Type, BooleanType>::Exec;
DCHECK_OK(func->AddKernel(base));
+ // duration type
+ base.signature = KernelSignature::Make({InputType::Array(Type::DURATION)}, uint64());
Review comment:
Might want to update (or remove) the function comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org