svn commit: r1648600 - /commons/proper/bsf/trunk/src/main/java/org/apache/bsf/BSFManager.java

[ro...@apache.org]

Author: rony
Date: Tue Dec 30 21:14:07 2014
New Revision: 1648600

URL: http://svn.apache.org/r1648600
Log:
[BSF-41] fix memory leak issue when terminating engines

Modified:
    commons/proper/bsf/trunk/src/main/java/org/apache/bsf/BSFManager.java

Modified: commons/proper/bsf/trunk/src/main/java/org/apache/bsf/BSFManager.java
URL: http://svn.apache.org/viewvc/commons/proper/bsf/trunk/src/main/java/org/apache/bsf/BSFManager.java?rev=1648600&r1=1648599&r2=1648600&view=diff
==============================================================================
--- commons/proper/bsf/trunk/src/main/java/org/apache/bsf/BSFManager.java (original)
+++ commons/proper/bsf/trunk/src/main/java/org/apache/bsf/BSFManager.java Tue Dec 30 21:14:07 2014
@@ -71,6 +71,7 @@ import org.apache.bsf.util.ObjectRegistr
 
            2012-01-29, ---rgf, - context class loader may not be set, account for it (2009-09-10)
                                - static constructor: fixed logic error in fallback code for getResources() (2011-01-08)
+           2014-12-30, ---rgf, - remove memory leak when terminating engines, cf. issue [BSF-41]
 */
 
 public class BSFManager {
@@ -79,7 +80,7 @@ public class BSFManager {
     // and "yyyy" a four digit year, "mm" a two digit month, "dd" a two digit day.
     //
     // Example: "250.20120129" stands for: BSF version "2.5.0" as of "2012-01-29"
-    protected static String version="250.20120129";
+    protected static String version="250.20141230";
 
     // table of registered scripting engines
     protected static Hashtable registeredEngines = new Hashtable();
@@ -958,6 +959,7 @@ public class BSFManager {
         BSFEngine engine;
         while (enginesEnum.hasMoreElements()) {
             engine = (BSFEngine) enginesEnum.nextElement();
+            pcs.removePropertyChangeListener(engine);   // rgf, 2014-12-30: removing memory leak
             engine.terminate();
         }