You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/30 11:14:58 UTC

[GitHub] [cloudstack] ravening commented on a change in pull request #5723: server: Fix NPE while adding network to VPC

ravening commented on a change in pull request #5723:
URL: https://github.com/apache/cloudstack/pull/5723#discussion_r759176237



##########
File path: server/src/main/java/com/cloud/network/element/VpcVirtualRouterElement.java
##########
@@ -348,6 +348,9 @@ public Provider getProvider() {
 
         //1st time it runs the domain router of the VM shall be returned
         List<DomainRouterVO> routers = super.getRouters(network, dest);
+        if (routers == null) {

Review comment:
       @weizhouapache I tried to deploy a new vpc, with tiers and vm in it but the control never reached the line 356 of this file. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org