[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38844: [SPARK-41328][CONNECT][PYTHON] Add logical and string API to Column

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38844:
URL: https://github.com/apache/spark/pull/38844#discussion_r1035441576


##########
python/pyspark/sql/connect/column.py:
##########
@@ -352,17 +365,307 @@ def __init__(self, expr: Expression) -> None:
     __rpow__ = _bin_op("pow", reverse=True)
     __ge__ = _bin_op(">=")
     __le__ = _bin_op("<=")
-    # __eq__ = _bin_op("==")  # ignore [assignment]
+
+    _eqNullSafe_doc = """
+        Equality test that is safe for null values.
+        .. versionadded:: 2.3.0
+        Parameters

Review Comment:
   ```suggestion
           Equality test that is safe for null values.
   
           .. versionadded:: 3.4.0
   
           Parameters
   ```



##########
python/pyspark/sql/connect/column.py:
##########
@@ -352,17 +365,307 @@ def __init__(self, expr: Expression) -> None:
     __rpow__ = _bin_op("pow", reverse=True)
     __ge__ = _bin_op(">=")
     __le__ = _bin_op("<=")
-    # __eq__ = _bin_op("==")  # ignore [assignment]
+
+    _eqNullSafe_doc = """
+        Equality test that is safe for null values.
+        .. versionadded:: 2.3.0
+        Parameters
+        ----------
+        other
+            a value or :class:`Column`

Review Comment:
   ```suggestion
               a value or :class:`Column`
   
   ```
   
   Otherwise, the documentation format is broken



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org