You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/13 07:17:13 UTC
Review Request 24631: Refactored the protobuf message comparison logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24631/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
See summary. We need update CommandInfo comparison code to deal with the new fields.
Diffs
-----
src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
Diff: https://reviews.apache.org/r/24631/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 24631: Refactored the protobuf message comparison logic.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24631/#review50407
-----------------------------------------------------------
Ship it!
Not exactly the most efficient way of doing this, but let's profile and optimize later if necessary! ;-)
- Benjamin Hindman
On Aug. 13, 2014, 5:17 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24631/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:17 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. We need update CommandInfo comparison code to deal with the new fields.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee
>
> Diff: https://reviews.apache.org/r/24631/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>