[GitHub] [solr] cpoerschke commented on a change in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #96:
URL: https://github.com/apache/solr/pull/96#discussion_r645380954



##########
File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##########
@@ -40,12 +41,15 @@
  * solution. There will be a follow up with a SIP for a schema API design.
  */
 public class CircuitBreakerManager implements PluginInfoInitialized {
+  private final SolrCore core;

Review comment:
       > There should be some flag on the Threadpool I think, whether the request is internal (initiated by Solr) or external. Don't recall the details.
   
   Via https://github.com/apache/solr/pull/112 I learnt about https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.8.2/solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java#L247-L256 i.e. `ExecutorUtil.(setServerThreadFlag|isSolrServerThread)`.
   
   That may or may not be the flag you meant.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org