You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by xubo245 <gi...@git.apache.org> on 2017/11/02 07:47:34 UTC
[GitHub] spark pull request #19639: [SPARK-22423][SQL] The TestHiveSingleton.scala fi...
GitHub user xubo245 opened a pull request:
https://github.com/apache/spark/pull/19639
[SPARK-22423][SQL] The TestHiveSingleton.scala file should be in scala directory
## What changes were proposed in this pull request?
The TestHiveSingleton.scala file is moved into scala directory from java directory
## How was this patch tested?
Base test class for Hive.
No new test case in this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/spark scalaDirectory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19639
----
commit bfda9345c618a9656ccbe7b472e9e1963d325b45
Author: xubo245 <60...@qq.com>
Date: 2017-11-02T07:30:52Z
[SPARK-22423][SQL] The TestHiveSingleton.scala file should be in scala directory
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19639: [SPARK-22423][SQL] The TestHiveSingleton.scala fi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19639#discussion_r148728531
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHiveSingleton.scala ---
@@ -24,7 +24,6 @@ import org.apache.spark.sql.SparkSession
import org.apache.spark.sql.hive.HiveExternalCatalog
import org.apache.spark.sql.hive.client.HiveClient
-
--- End diff --
Don't modify the file, just move it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19639: [SPARK-22423][SQL] The TestHiveSingleton.scala file shou...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/spark/pull/19639
Ok, I will fix all and update the PR title Later.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19639: [SPARK-22423][SQL] Scala test source files like TestHive...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19639
**[Test build #3980 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3980/testReport)** for PR 19639 at commit [`dc2858d`](https://github.com/apache/spark/commit/dc2858d420dba3e6a9ef80b950cfb9323acbb828).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19639: [SPARK-22423][SQL] Scala test source files like TestHive...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19639
**[Test build #3980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3980/testReport)** for PR 19639 at commit [`dc2858d`](https://github.com/apache/spark/commit/dc2858d420dba3e6a9ef80b950cfb9323acbb828).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class IdentifiableSuite extends SparkFunSuite `
* ` class Test(override val uid: String) extends Identifiable `
* `trait JavaTestBase extends TestSuiteBase `
* `class JavaStreamingListenerWrapperSuite extends SparkFunSuite `
* `class TestJavaStreamingListener extends JavaStreamingListener `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19639: [SPARK-22423][SQL] The TestHiveSingleton.scala fi...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19639#discussion_r148764458
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHiveSingleton.scala ---
@@ -24,7 +24,6 @@ import org.apache.spark.sql.SparkSession
import org.apache.spark.sql.hive.HiveExternalCatalog
import org.apache.spark.sql.hive.client.HiveClient
-
--- End diff --
ok
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19639: [SPARK-22423][SQL] The TestHiveSingleton.scala file shou...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19639
See my comment on the JIRA. Let's fix all four instances at once. (And update the PR title)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19639: [SPARK-22423][SQL] Scala test source files like T...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19639
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19639: [SPARK-22423][SQL] Scala test source files like TestHive...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/spark/pull/19639
I have fixed all four instances and update the PR title.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19639: [SPARK-22423][SQL] Scala test source files like TestHive...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19639
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19639: [SPARK-22423][SQL] The TestHiveSingleton.scala file shou...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19639
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org