You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Peter Bacsko (JIRA)" <ji...@apache.org> on 2019/01/23 13:53:00 UTC

[jira] [Commented] (YARN-9134) No test coverage for redefining FPGA / GPU resource types in TestResourceUtils

    [ https://issues.apache.org/jira/browse/YARN-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750005#comment-16750005 ] 

Peter Bacsko commented on YARN-9134:
------------------------------------

Some ideas:

1. Complete the javadoc for {{setupResourceTypes()}}
2. If that method is dangerous, you could then catch the exception, do a cleanup right there then re-throw the exception

> No test coverage for redefining FPGA / GPU resource types in TestResourceUtils
> ------------------------------------------------------------------------------
>
>                 Key: YARN-9134
>                 URL: https://issues.apache.org/jira/browse/YARN-9134
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9134.001.patch
>
>
> The patch also includes some trivial code cleanup.
> Also, setupResourceTypes has been deprecated as it is dangerous to use, see the javadoc for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org