You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/06 01:57:38 UTC

[GitHub] [thrift] thedebugger opened a new pull request #2255: Throw exception when there is no data in curl transport

thedebugger opened a new pull request #2255:
URL: https://github.com/apache/thrift/pull/2255


   My team has been running a fork of php thrift (super old) and we had an issue parsing never terminates when body is empty. After looking open source code, current master is not vulnerable to our specific use case because curl throws an error when response is empty. However, I feel that explicitly throwing an error when there is no more data available in curl transport is beneficial in the case if caller has bugs. Let me know what you folks think. And Happy to add test and jira if that makes sense. Thxs
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   Happy to create it if we my problem/changes make sense.
   - [] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] stale[bot] commented on pull request #2255: Throw exception when there is no data in curl transport

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2255:
URL: https://github.com/apache/thrift/pull/2255#issuecomment-748615039


   This issue has been automatically closed due to inactivity. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] stale[bot] commented on pull request #2255: Throw exception when there is no data in curl transport

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2255:
URL: https://github.com/apache/thrift/pull/2255#issuecomment-743934728


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] thedebugger commented on pull request #2255: Throw exception when there is no data in curl transport

Posted by GitBox <gi...@apache.org>.
thedebugger commented on pull request #2255:
URL: https://github.com/apache/thrift/pull/2255#issuecomment-704454837


   @Jens-G thanks for the feedback. I'll start doing that today. But the patch makes sense...right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] stale[bot] closed pull request #2255: Throw exception when there is no data in curl transport

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #2255:
URL: https://github.com/apache/thrift/pull/2255


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2255: Throw exception when there is no data in curl transport

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2255:
URL: https://github.com/apache/thrift/pull/2255#issuecomment-704068568


   >  And Happy to add test and jira if that makes sense. Thxs
   I was about to ask for it, so yes, please do.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org