You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Rogan Carr <ro...@gmail.com> on 2017/06/29 01:10:12 UTC
REEF-1817: Fix CoreCLR issues in REEF.Common
Hi All,
I'd like to start fixing Core compatibility issues in REEF.NET, and
REEF.Common seems like a good place to start (I only see 48
incompatibilities, and many of these seem trivial).
I opened REEF-1817 [1] to track this work as a sub-task of REEF-334 [2].
Does this make sense? Is there any reason to start somewhere else in the
codebase?
Best,
Rogan
[1] https://issues.apache.org/jira/browse/REEF-1817
[2] https://issues.apache.org/jira/browse/REEF-334
Re: REEF-1817: Fix CoreCLR issues in REEF.Common
Posted by Rogan Carr <ro...@gmail.com>.
Hi Markus,
> Hope this helps
Yes, very much so!
>Executables need to target `.NET Core 2.0` and `.NET Framework 4.6.1`.
So, I'll target projects like Org.Apache.REEF.Examples* that produce
executables for `.NET Core 2.0` and `.NET Framework 4.6.1`.
>Libraries need to target `.NET Standard 2.0`.
And, I'll target libraries like Org.Apache.REEF.Common for `.NET Standard
2.0`.
Thanks for your help!
Best,
Rogan
On Wed, Jul 5, 2017 at 5:16 PM, Markus Weimer <ma...@weimo.de> wrote:
> On Wed, Jul 5, 2017 at 5:03 PM, Rogan Carr <ro...@gmail.com> wrote:
> > Quick question on CoreCLR Compatibility: For REEF.NET, we just need .NET
> > Standard 2.0, .NET Core 2.0 for DLLs, right? Am I correct that only
> > executables need ".NET Core + Platform Extensions 1.0"?
>
> Executables need to target `.NET Core 2.0` and `.NET Framework 4.6.1`.
> Libraries need to target `.NET Standard 2.0`.
>
> Hope this helps,
>
> Markus
>
Re: REEF-1817: Fix CoreCLR issues in REEF.Common
Posted by Markus Weimer <ma...@weimo.de>.
On Wed, Jul 5, 2017 at 5:03 PM, Rogan Carr <ro...@gmail.com> wrote:
> Quick question on CoreCLR Compatibility: For REEF.NET, we just need .NET
> Standard 2.0, .NET Core 2.0 for DLLs, right? Am I correct that only
> executables need ".NET Core + Platform Extensions 1.0"?
Executables need to target `.NET Core 2.0` and `.NET Framework 4.6.1`.
Libraries need to target `.NET Standard 2.0`.
Hope this helps,
Markus
Re: REEF-1817: Fix CoreCLR issues in REEF.Common
Posted by Rogan Carr <ro...@gmail.com>.
Hi All,
Quick question on CoreCLR Compatibility: For REEF.NET, we just need .NET
Standard 2.0, .NET Core 2.0 for DLLs, right? Am I correct that only
executables need ".NET Core + Platform Extensions 1.0"?
Thanks for your help!
Best,
Rogan
On Wed, Jul 5, 2017 at 4:57 PM, Rogan Carr <ro...@gmail.com> wrote:
> Hi All,
>
> REEF.Common may be a bit more difficult to convert, as it uses a library,
> PerformanceCounters, that is not available in the CLR (see my comments on
> 1817 [1]). I'll investigate more to see what the impact will be.
>
> In the meantime, I created REEF-1821 to fix CoreCLR compatibility issues
> that arise from using non-compliant exceptions [2].
>
> Best,
> Rogan
>
> [1] https://issues.apache.org/jira/browse/REEF-1817
> [2] https://issues.apache.org/jira/browse/REEF-1821
>
> On Thu, Jun 29, 2017 at 4:05 AM, Byung-Gon Chun <bg...@gmail.com> wrote:
>
>> Welcome, Rogan!
>>
>> On Thu, Jun 29, 2017 at 11:02 AM, Markus Weimer <ma...@weimo.de> wrote:
>>
>> > Welcome to the team, Rogan! The plan you mention makes sense. -- Markus
>> >
>>
>>
>>
>> --
>> Byung-Gon Chun
>>
>
>
Re: REEF-1817: Fix CoreCLR issues in REEF.Common
Posted by Rogan Carr <ro...@gmail.com>.
Hi All,
REEF.Common may be a bit more difficult to convert, as it uses a library,
PerformanceCounters, that is not available in the CLR (see my comments on
1817 [1]). I'll investigate more to see what the impact will be.
In the meantime, I created REEF-1821 to fix CoreCLR compatibility issues
that arise from using non-compliant exceptions [2].
Best,
Rogan
[1] https://issues.apache.org/jira/browse/REEF-1817
[2] https://issues.apache.org/jira/browse/REEF-1821
On Thu, Jun 29, 2017 at 4:05 AM, Byung-Gon Chun <bg...@gmail.com> wrote:
> Welcome, Rogan!
>
> On Thu, Jun 29, 2017 at 11:02 AM, Markus Weimer <ma...@weimo.de> wrote:
>
> > Welcome to the team, Rogan! The plan you mention makes sense. -- Markus
> >
>
>
>
> --
> Byung-Gon Chun
>
Re: REEF-1817: Fix CoreCLR issues in REEF.Common
Posted by Byung-Gon Chun <bg...@gmail.com>.
Welcome, Rogan!
On Thu, Jun 29, 2017 at 11:02 AM, Markus Weimer <ma...@weimo.de> wrote:
> Welcome to the team, Rogan! The plan you mention makes sense. -- Markus
>
--
Byung-Gon Chun
Re: REEF-1817: Fix CoreCLR issues in REEF.Common
Posted by Markus Weimer <ma...@weimo.de>.
Welcome to the team, Rogan! The plan you mention makes sense. -- Markus