You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/08/05 16:35:08 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #13080: fix: recover auto rotation for line symbol.
100pah opened a new pull request #13080:
URL: https://github.com/apache/incubator-echarts/pull/13080
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
In Line.js (used by graph and markLine), when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time (like when drag graph or move dataZoom).
#12392 support the feature of support user specified symbol rotation in Line.js
Line.js is used by graph and markLine and might other places.
But when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time.
The scenario of "render at the second time" are like dragging force layout graph or move dataZoom.
See the triangle below:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13080: fix: recover auto rotation for line symbol.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13080:
URL: https://github.com/apache/incubator-echarts/pull/13080#issuecomment-669299267
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13080: fix: recover auto rotation for line symbol.
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13080:
URL: https://github.com/apache/incubator-echarts/pull/13080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13080: fix: recover auto rotation for line symbol.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13080:
URL: https://github.com/apache/incubator-echarts/pull/13080#issuecomment-669639596
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org