You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/25 18:20:07 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5620: arm/armv7-a: Remove CONFIG_SMP guard from arm_scu.c

xiaoxiang781216 opened a new pull request #5620:
URL: https://github.com/apache/incubator-nuttx/pull/5620


   ## Summary
   since ACTLR.SMP need enable to make cache work on Cortex A7:
   https://developer.arm.com/documentation/ddi0464/f/CHDBIEIF
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #5620: arm/armv7-a: Remove CONFIG_SMP guard from arm_scu.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #5620:
URL: https://github.com/apache/incubator-nuttx/pull/5620


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5620: arm/armv7-a: Remove CONFIG_SMP guard from arm_scu.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5620:
URL: https://github.com/apache/incubator-nuttx/pull/5620#issuecomment-1051640708


   > @xiaoxiang781216
   > 
   > I noticed that `arm_enable_smp()` is currently called in `arch/arm/src/imx6` only. So, for example, am335x which has Cortex-A8 would not be affected.
   
   Yes, where to call arm_enable_smp is controlled by the chip code, not arch common code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #5620: arm/armv7-a: Remove CONFIG_SMP guard from arm_scu.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on pull request #5620:
URL: https://github.com/apache/incubator-nuttx/pull/5620#issuecomment-1051405499


   @xiaoxiang781216 
   
   How about the Cortex-A8 case which has no SCU?
   I think that the SCU exists only on the MPCore.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5620: arm/armv7-a: Remove CONFIG_SMP guard from arm_scu.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5620:
URL: https://github.com/apache/incubator-nuttx/pull/5620#issuecomment-1051405499


   @xiaoxiang781216 
   
   How about the Cortex-A8 case which has no SCU?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5620: arm/armv7-a: Remove CONFIG_SMP guard from arm_scu.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5620:
URL: https://github.com/apache/incubator-nuttx/pull/5620#issuecomment-1051590642


   @xiaoxiang781216 
   
   I noticed that `arm_enable_smp()` is currently called in `arch/arm/src/imx6` only.
   So, for example, am335x which has Cortex-A8 would not be affected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5620: arm/armv7-a: Remove CONFIG_SMP guard from arm_scu.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5620:
URL: https://github.com/apache/incubator-nuttx/pull/5620#issuecomment-1051574607


   > @xiaoxiang781216
   > 
   > How about the Cortex-A8 case which has no SCU? I think that the SCU exists only on the MPCore.
   
   Yes, but sometime, it's useful to run independent NuttX instance on each PMCore. If SCU function is guarded by CONFIG_SMP, we lose this possibility. On the other hand, arm_scu.c just contain passive utility functions, the chip developer should have enough knowledge to know whether to call these functions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org