[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change

[GitBox <gi...@apache.org>]

rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-786955706


   @abbccdda, @cmccabe.  Ported from #10199 to discuss separately.  We used to see this error message in `verifiable_producer.log` when `security_protocol='PLAINTEXT', interbroker_security_protocol='SSL'`:
   
   ```
   WARN [Producer clientId=producer-1] Error while fetching metadata with correlation id 1 : {test_topic=LEADER_NOT_AVAILABLE} (org.apache.kafka.clients.NetworkClient)
   ```
   The test does a `grep LEADER_NOT_AVAILABLE` on the log in this case, and it used to pass.
   
   Now we are instead seeing this in the log file:
   
   ```
   WARN [Producer clientId=producer-1] Error while fetching metadata with correlation id 1 : {test_topic=INVALID_REPLICATION_FACTOR} (org.apache.kafka.clients.NetworkClient)
   ```
   
   And of course now the test fails.
   
   The `INVALID_REPLICATION_FACTOR` is coming from the auto topic creation manager as I described above.
   
   It is a simple matter to make the test pass -- I have confirmed that it passes if we `grep` for `INVALID_REPLICATION_FACTOR` in the log file instead of `LEADER_NOT_AVAILABLE`.
   
   I think we just need to decide if this change in behavior is acceptable or not.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org