You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/06/17 15:17:35 UTC

[GitHub] [airflow] hussein-awala commented on a diff in pull request #31833: Remove right trailing / from webserver base_url

hussein-awala commented on code in PR #31833:
URL: https://github.com/apache/airflow/pull/31833#discussion_r1233077597


##########
airflow/models/taskinstance.py:
##########
@@ -758,7 +758,7 @@ def generate_command(
     def log_url(self) -> str:
         """Log URL for TaskInstance."""
         iso = quote(self.execution_date.isoformat())
-        base_url = conf.get_mandatory_value("webserver", "BASE_URL")
+        base_url = conf.get_mandatory_value("webserver", "BASE_URL").rstrip("/")

Review Comment:
   I will check how can we do that for a specific config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org