You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/07/28 03:16:33 UTC

[GitHub] [spark] advancedxy commented on pull request #37616: [SPARK-40178][PYTHON][SQL] Fix partitioning hint parameters in PySpark

advancedxy commented on PR #37616:
URL: https://github.com/apache/spark/pull/37616#issuecomment-1654917282

   @mhconradt are you still working on this? If not, I would like to pick this up.
   
   > Came across this wanting to test out the rebalance hint in pyspark (since it looks like rebalance can only be used as a hint right now). Does it make more sense to support strings directly in ResolveHints? It is pretty awkward that SQL hints get interpreted as expressions, but DataFrame hints don't. It's definitely awkward having to use $"col".expr even on the Scala side. And in ResolveHints it already supports the number of partitions either being an Literal or an integer
   
   yeah. I think the hint method in the Dataset side should support string/integer parameters directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org